Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-04-03 Thread Maxime Ripard
Hi Niklas, Thanks for your review, On Thu, Mar 29, 2018 at 03:32:55PM +0200, Niklas Söderlund wrote: > > diff --git a/drivers/media/platform/cadence/Kconfig > > b/drivers/media/platform/cadence/Kconfig > > new file mode 100644 > > index ..18f061e5cbd1 > > --- /dev/null > > +++ b/driv

Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-03-29 Thread Niklas Söderlund
Hi Maxime, Thanks for your patch. On 2018-02-15 14:33:35 +0100, Maxime Ripard wrote: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes, > or w

Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-03-02 Thread Maxime Ripard
Hi Benoit, On Thu, Mar 01, 2018 at 02:09:18PM -0600, Benoit Parrot wrote: > > + /* > > +* FIXME: Once we'll have internal D-PHY support, the check > > +* will need to be removed. > > +*/ > > + if (csi2rx->has_internal_dphy) { > > + dev_err(&pdev->dev, "Internal D-PHY not

Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-03-01 Thread Benoit Parrot
Maxime, Thank you for the patch. Maxime Ripard wrote on Thu [2018-Feb-15 14:33:35 +0100]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes,

[PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-02-15 Thread Maxime Ripard
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a bridge between a CSI-2 bus and pixel grabbers. It supports operating with internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. It also support dynamic mappin