Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-30 Thread Guennadi Liakhovetski
Hi Matsubara-san, On Tue, 30 Jul 2013, Katsuya MATSUBARA wrote: > > Hi Guennadi, > > From: Guennadi Liakhovetski > Date: Fri, 26 Jul 2013 13:11:52 +0200 (CEST) > > > Hello Matsubara-san > > > > On Thu, 25 Jul 2013, Katsuya MATSUBARA wrote: > > > >> > >> Hi Vladimir, [snip] > >> I tested

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-30 Thread Katsuya MATSUBARA
Hi Guennadi, From: Guennadi Liakhovetski Date: Fri, 26 Jul 2013 13:11:52 +0200 (CEST) > Hello Matsubara-san > > On Thu, 25 Jul 2013, Katsuya MATSUBARA wrote: > >> >> Hi Vladimir, >> >> From: Vladimir Barinov >> Date: Thu, 25 Jul 2013 10:55:51 +0400 >> >> > Hi Matsubara-san, >> > >> > O

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-26 Thread Guennadi Liakhovetski
Hello Matsubara-san On Thu, 25 Jul 2013, Katsuya MATSUBARA wrote: > > Hi Vladimir, > > From: Vladimir Barinov > Date: Thu, 25 Jul 2013 10:55:51 +0400 > > > Hi Matsubara-san, > > > > On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote: > >> Hi Vladimir, > >> > >> Thank you for the revised p

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-25 Thread Katsuya MATSUBARA
Hi Vladimir, From: Vladimir Barinov Date: Thu, 25 Jul 2013 10:55:51 +0400 > Hi Matsubara-san, > > On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote: >> Hi Vladimir, >> >> Thank you for the revised patch. >> >> From: Sergei Shtylyov >> Date: Sat, 20 Jul 2013 03:14:34 +0400 >> >>> From: Vlad

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Vladimir Barinov
Hi Matsubara-san, On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote: Hi Vladimir, Thank you for the revised patch. From: Sergei Shtylyov Date: Sat, 20 Jul 2013 03:14:34 +0400 From: Vladimir Barinov Add Renesas R-Car VIN (Video In) V4L2 driver. Based on the patch by Phil Edworthy. Signe

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Katsuya MATSUBARA
Hi Vladimir, Thank you for the revised patch. From: Sergei Shtylyov Date: Sat, 20 Jul 2013 03:14:34 +0400 > From: Vladimir Barinov > > Add Renesas R-Car VIN (Video In) V4L2 driver. > > Based on the patch by Phil Edworthy . > > Signed-off-by: Vladimir Barinov > [Sergei: removed deprecate

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Guennadi Liakhovetski
Hi Vladimir On Wed, 24 Jul 2013, Vladimir Barinov wrote: > Hi Guennadi, > > Thank you for the v8 review. > > On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote: > > [snip] > > > + /* output format */ > > > + switch (icd->current_fmt->host_fmt->fourcc) { > > > + case V4L2_PIX_FMT_NV16: > > > +

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Guennadi Liakhovetski
On Wed, 24 Jul 2013, Sergei Shtylyov wrote: > Hello. > > On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote: > > > > From: Vladimir Barinov > > > > Add Renesas R-Car VIN (Video In) V4L2 driver. > > > > Based on the patch by Phil Edworthy . > > > > Signed-off-by: Vladimir Barinov > > > [Ser

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Sergei Shtylyov
Hello. On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote: From: Vladimir Barinov Add Renesas R-Car VIN (Video In) V4L2 driver. Based on the patch by Phil Edworthy . Signed-off-by: Vladimir Barinov [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id' valu

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Vladimir Barinov
Hi Guennadi, Thank you for the v8 review. On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote: [snip] + /* output format */ + switch (icd->current_fmt->host_fmt->fourcc) { + case V4L2_PIX_FMT_NV16: + iowrite32(ALIGN(cam->width * cam->height, 0x80), +

Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-24 Thread Guennadi Liakhovetski
Hi Sergei, Vladimir So, looks like we're almost there. checkpatch.pl looks pretty good too, I don't care about > 80 chars, Kconfig seems to be a dull one, have a look at msleep(1) warning whether it bothers you. On Sat, 20 Jul 2013, Sergei Shtylyov wrote: > From: Vladimir Barinov > > Add Ren

[PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

2013-07-19 Thread Sergei Shtylyov
From: Vladimir Barinov Add Renesas R-Car VIN (Video In) V4L2 driver. Based on the patch by Phil Edworthy . Signed-off-by: Vladimir Barinov [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id' values, reordered rcar_vin_id_table[] entries, removed senseless parens f