Re: [PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller

2015-04-30 Thread Pavel Machek
> +struct aat1290_led_config_data { > + /* maximum LED current in movie mode */ > + u32 max_mm_current; > + /* maximum LED current in flash mode */ > + u32 max_flash_current; > + /* maximum flash timeout */ > + u32 max_flash_tm; Ok, the comments tell us what should be alre

Re: [PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller

2015-04-28 Thread Bryan Wu
On Tue, Apr 28, 2015 at 4:36 AM, Sakari Ailus wrote: > On Tue, Apr 28, 2015 at 09:18:45AM +0200, Jacek Anaszewski wrote: >> This patch adds a driver for the 1.5A Step-Up Current Regulator >> for Flash LEDs. The device is programmed through a Skyworks proprietary >> AS2Cwire serial digital interfac

Re: [PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller

2015-04-28 Thread Sakari Ailus
On Tue, Apr 28, 2015 at 09:18:45AM +0200, Jacek Anaszewski wrote: > This patch adds a driver for the 1.5A Step-Up Current Regulator > for Flash LEDs. The device is programmed through a Skyworks proprietary > AS2Cwire serial digital interface. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungm

[PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller

2015-04-28 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- driver