Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, This is getting very close. Besides this round of review comments the main blocker is mbus_config. But Thomasz is looking at that, so I will wait until that is resolved. Also for your v7 include the patches from Sakari that add Meta Output support. This patch series relies on those, so

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, On Fri, Mar 09, 2018 at 01:05:28PM +0800, Jacob Chen wrote: > 2018-03-09 12:09 GMT+08:00 Baruch Siach : > > On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > >> 2018-03-08 20:02 GMT+08:00 Baruch Siach : > >> > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > >> >

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Baruch, 2018-03-09 12:09 GMT+08:00 Baruch Siach : > Hi Jacob, > > On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: >> 2018-03-08 20:02 GMT+08:00 Baruch Siach : >> > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: >> >> This patch series add a ISP(Camera) v4l2 driver for r

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > 2018-03-08 20:02 GMT+08:00 Baruch Siach : > > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > >> This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > >> SoC. > >> > >> Wiki Pages: > >> htt

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Baruch, 2018-03-08 20:02 GMT+08:00 Baruch Siach : > Hi Jacob, > > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: >> This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 >> SoC. >> >> Wiki Pages: >> http://opensource.rock-chips.com/wiki_Rockchip-isp1 >> >> The

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

Hi Jacob, On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > SoC. > > Wiki Pages: > http://opensource.rock-chips.com/wiki_Rockchip-isp1 > > The deprecated g_mbus_config op is not dropped in V6 because i am

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

On Thu, Mar 8, 2018 at 6:47 PM, Jacob Chen wrote: > From: Jacob Chen > > changes in V6: > - add mipi txrx phy support > - remove bool and enum from uapi header > - add buf_prepare op > - correct some spelling problems > - return all queued buffers when starting stream failed Thanks Jac

[PATCH v6 00/17] Rockchip ISP1 Driver

From: Jacob Chen changes in V6: - add mipi txrx phy support - remove bool and enum from uapi header - add buf_prepare op - correct some spelling problems - return all queued buffers when starting stream failed changes in V5: Sync with local changes, - fix the SP height limit - spee