Re: [PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-01 Thread Sakari Ailus
Hi Laurent, On Fri, Sep 01, 2017 at 11:55:43AM +0300, Laurent Pinchart wrote: ... > > >> +static int parse_endpoint( > > >> +struct device *dev, struct v4l2_async_notifier *notifier, > > >> +struct fwnode_handle *endpoint, unsigned int asd_struct_size, > > >> +int (*parse_s

Re: [PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-01 Thread Laurent Pinchart
Hi Sakari, On Tuesday, 29 August 2017 17:31:21 EEST Sakari Ailus wrote: > On Tue, Aug 29, 2017 at 05:02:54PM +0300, Laurent Pinchart wrote: > > On Tuesday, 29 August 2017 14:03:12 EEST Sakari Ailus wrote: > >> The current practice is that drivers iterate over their endpoints and > >> parse each en

Re: [PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-29 Thread Sakari Ailus
Hi Laurent, On Tue, Aug 29, 2017 at 05:02:54PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. Thanks for the review! > > On Tuesday, 29 August 2017 14:03:12 EEST Sakari Ailus wrote: > > The current practice is that drivers iterate over their endpoints and > > parse ea

Re: [PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-29 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tuesday, 29 August 2017 14:03:12 EEST Sakari Ailus wrote: > The current practice is that drivers iterate over their endpoints and > parse each endpoint separately. This is very similar in a number of > drivers, implement a generic function for the job. Drive

[PATCH v5 4/5] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-29 Thread Sakari Ailus
The current practice is that drivers iterate over their endpoints and parse each endpoint separately. This is very similar in a number of drivers, implement a generic function for the job. Driver specific matters can be taken into account in the driver specific callback. Convert the omap3isp as an