Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-09-21 Thread Sakari Ailus
Hi Todor, Todor Tomov wrote: > Hi Sakari, > > One more question below: > > On 08/25/2016 10:18 AM, Sakari Ailus wrote: > + > +static struct v4l2_subdev_core_ops ov5645_core_ops = { > + .s_power = ov5645_s_power, > +}; > + > +static struct v4l2_subdev_video_ops ov5645_vide

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-09-21 Thread Todor Tomov
Hi Sakari, One more question below: On 08/25/2016 10:18 AM, Sakari Ailus wrote: + +static struct v4l2_subdev_core_ops ov5645_core_ops = { + .s_power = ov5645_s_power, +}; + +static struct v4l2_subdev_video_ops ov5645_video_ops = { + .s_stream = ov5645_s_stream

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-25 Thread Sakari Ailus
Hi Todor, On Thu, Aug 25, 2016 at 04:30:33PM +0300, Todor Tomov wrote: > Hi Sakari, Rob, > > On 08/25/2016 10:18 AM, Sakari Ailus wrote: > > Hi Todor, > > > > On Wed, Aug 24, 2016 at 06:24:31PM +0300, Todor Tomov wrote: > >> Hi Sakari, > >> > >> Thanks a lot for the time spent to review the driv

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-25 Thread Todor Tomov
Hi Sakari, Rob, On 08/25/2016 10:18 AM, Sakari Ailus wrote: > Hi Todor, > > On Wed, Aug 24, 2016 at 06:24:31PM +0300, Todor Tomov wrote: >> Hi Sakari, >> >> Thanks a lot for the time spent to review the driver! > > You're welcome! :-) > >> I have a few responses bellow. >> >> >> On 08/24/2016 0

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-25 Thread Sakari Ailus
Hi Todor, On Wed, Aug 24, 2016 at 06:24:31PM +0300, Todor Tomov wrote: > Hi Sakari, > > Thanks a lot for the time spent to review the driver! You're welcome! :-) > I have a few responses bellow. > > > On 08/24/2016 01:17 PM, Sakari Ailus wrote: > > Hi Todor, > > > > Thank you for the patch.

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-24 Thread Todor Tomov
Hi Sakari, Thanks a lot for the time spent to review the driver! I have a few responses bellow. On 08/24/2016 01:17 PM, Sakari Ailus wrote: > Hi Todor, > > Thank you for the patch. Please see my comments below. > > On Fri, Jul 08, 2016 at 05:54:39PM +0300, Todor Tomov wrote: >> The ov5645 sens

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-24 Thread Sakari Ailus
Hi Todor, Thank you for the patch. Please see my comments below. On Fri, Jul 08, 2016 at 05:54:39PM +0300, Todor Tomov wrote: > The ov5645 sensor from Omnivision supports up to 2592x1944 > and CSI2 interface. > > The driver adds support for the following modes: > - 1280x960 > - 1920x1080 > - 259

[PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-07-08 Thread Todor Tomov
The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |