Re: [PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

2016-09-05 Thread Hans Verkuil
On 09/04/2016 10:05 PM, Helen Koike wrote: > Hi Hans, > > Thank you for your review. > > On 2016-08-22 07:57 AM, Hans Verkuil wrote: >> Hi Helen, >> >> A few small code comments are below. >> >> Note that if I try to capture I see these two messages in the kernel log: >> >> [588197.368145] vimc v

Re: [PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

2016-09-04 Thread Helen Koike
Hi Hans, Thank you for your review. On 2016-08-22 07:57 AM, Hans Verkuil wrote: Hi Helen, A few small code comments are below. Note that if I try to capture I see these two messages in the kernel log: [588197.368145] vimc vimc.0: Entity type for entity Sensor A was not initialized! [588197.

Re: [PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

2016-08-22 Thread Hans Verkuil
Hi Helen, A few small code comments are below. Note that if I try to capture I see these two messages in the kernel log: [588197.368145] vimc vimc.0: Entity type for entity Sensor A was not initialized! [588197.368169] vimc vimc.0: Entity type for entity Sensor B was not initialized! I also c

[PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

2016-08-17 Thread Helen Koike
From: Helen Fornazier First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike --- Patch based in media/master tree, and available here