Re: [PATCH v4 7/7] V4L: Events: Support all events

2010-02-19 Thread Sakari Ailus
Hans Verkuil wrote: >> Then don't call it v4l2_event_subscribe_all if it only subscribes to a set >> of >> event :-) >> >>> For each event this function would then call: >>> >>> fh->vdev->ioctl_ops->vidioc_subscribe_event(fh, sub); >>> >>> The nice thing about that is that in the driver you have a

Re: [PATCH v4 7/7] V4L: Events: Support all events

2010-02-15 Thread Hans Verkuil
> Hi Hans, > > On Saturday 13 February 2010 15:42:20 Hans Verkuil wrote: >> On Wednesday 10 February 2010 15:58:09 Sakari Ailus wrote: >> > Add support for subscribing all events with a special id >> V4L2_EVENT_ALL. >> > If V4L2_EVENT_ALL is subscribed, no other events may be subscribed. >> > Othe

Re: [PATCH v4 7/7] V4L: Events: Support all events

2010-02-15 Thread Laurent Pinchart
Hi Hans, On Saturday 13 February 2010 15:42:20 Hans Verkuil wrote: > On Wednesday 10 February 2010 15:58:09 Sakari Ailus wrote: > > Add support for subscribing all events with a special id V4L2_EVENT_ALL. > > If V4L2_EVENT_ALL is subscribed, no other events may be subscribed. > > Otherwise V4L2_EV

Re: [PATCH v4 7/7] V4L: Events: Support all events

2010-02-13 Thread Hans Verkuil
On Wednesday 10 February 2010 15:58:09 Sakari Ailus wrote: > Add support for subscribing all events with a special id V4L2_EVENT_ALL. If > V4L2_EVENT_ALL is subscribed, no other events may be subscribed. Otherwise > V4L2_EVENT_ALL is considered just as any other event. We should do this differentl

[PATCH v4 7/7] V4L: Events: Support all events

2010-02-10 Thread Sakari Ailus
Add support for subscribing all events with a special id V4L2_EVENT_ALL. If V4L2_EVENT_ALL is subscribed, no other events may be subscribed. Otherwise V4L2_EVENT_ALL is considered just as any other event. Signed-off-by: Sakari Ailus --- drivers/media/video/v4l2-event.c | 13 - incl