Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-24 Thread Akihiro TSUKADA
> Ok, but see the definition at the API spec: > > > http://linuxtv.org/downloads/v4l-dvb-apis/FE_GET_SET_PROPERTY.html#isdb-hierq-layers > > Basically, we use 0, 1, 2, 4 no matter what mode, e. g. I understand. (though I wonder why "4" is assigned instead of "3" when it is not a flag bit

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-24 Thread Mauro Carvalho Chehab
Em Wed, 24 Sep 2014 21:06:43 +0900 Akihiro TSUKADA escreveu: > > And TMCC returns it as 0, 1, 2, 3, 4, instead of 0, 1, 2, 4, 8. > > According to ARIB STD B31 3.15.6.7 (table 3.30), > The value is encoded and depends on the "mode". > so demods have to encode/decode anyway. Ok, but see the defin

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-24 Thread Akihiro TSUKADA
> And TMCC returns it as 0, 1, 2, 3, 4, instead of 0, 1, 2, 4, 8. According to ARIB STD B31 3.15.6.7 (table 3.30), The value is encoded and depends on the "mode". so demods have to encode/decode anyway. > AFAIKT, that doesn't work in Sound Broadcast mode, as the demod won't > be able to read the

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-24 Thread Mauro Carvalho Chehab
Em Wed, 24 Sep 2014 20:14:01 +0900 Akihiro TSUKADA escreveu: > > Btw, please check if your driver is handling it well, as the valid > > values for interleave are 0, 1, 2, 4 (actually, dib8000 also > > supports interleaving equal to 8, if sound_broadcast). > > I have no info on how to set time in

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-24 Thread Akihiro TSUKADA
> Btw, please check if your driver is handling it well, as the valid > values for interleave are 0, 1, 2, 4 (actually, dib8000 also > supports interleaving equal to 8, if sound_broadcast). I have no info on how to set time interleaving parameters, although I can read them as a part of TMCC info. I

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-24 Thread Mauro Carvalho Chehab
Em Wed, 24 Sep 2014 12:00:53 +0900 Akihiro TSUKADA escreveu: > > Hi, > > On 2014年09月24日 05:07, Mauro Carvalho Chehab wrote: > > I applied this series, as we're discussing it already for a long time, > > and it seems in a good shape... > > thanks for your reviews and advices. > > >> +static in

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-23 Thread Akihiro TSUKADA
Hi, On 2014年09月24日 05:07, Mauro Carvalho Chehab wrote: > I applied this series, as we're discussing it already for a long time, > and it seems in a good shape... thanks for your reviews and advices. >> +static int tc90522s_read_status(struct dvb_frontend *fe, fe_status_t >> *status) ..

Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-23 Thread Mauro Carvalho Chehab
Em Tue, 9 Sep 2014 02:20:42 +0900 tsk...@gmail.com escreveu: > From: Akihiro Tsukada > > This patch adds driver for tc90522 demodulator chips. > The chip contains 4 demod modules that run in parallel and are independently > controllable via separate I2C addresses. > Two of the modules are for I

[PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-09-08 Thread tskd08
From: Akihiro Tsukada This patch adds driver for tc90522 demodulator chips. The chip contains 4 demod modules that run in parallel and are independently controllable via separate I2C addresses. Two of the modules are for ISDB-T and the rest for ISDB-S. It is used in earthsoft pt3 cards. Note tha