Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation

2017-09-18 Thread Sakari Ailus
Hi Wenyou, On Mon, Sep 18, 2017 at 05:26:16PM +0800, Yang, Wenyou wrote: > Hi Sakari, > > > On 2017/9/18 15:35, Sakari Ailus wrote: > > Hi Wenyou, > > > > Thanks for the update. > > > > The driver exposes controls that are accessible through the sub-device node > > even if the device hasn't be

Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation

2017-09-18 Thread Yang, Wenyou
Hi Sakari, On 2017/9/18 15:35, Sakari Ailus wrote: Hi Wenyou, Thanks for the update. The driver exposes controls that are accessible through the sub-device node even if the device hasn't been powered on. Many ISP and bridge drivers will also power the sensor down once the last user of the us

Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation

2017-09-18 Thread Sakari Ailus
Hi Wenyou, Thanks for the update. The driver exposes controls that are accessible through the sub-device node even if the device hasn't been powered on. Many ISP and bridge drivers will also power the sensor down once the last user of the user space device nodes disappears. You could keep the de

[PATCH v4 3/3] media: ov7670: Add the s_power operation

2017-09-17 Thread Wenyou Yang
Add the s_power operation which is responsible for manipulating the power dowm mode through the PWDN pin and the reset operation through the RESET pin. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: None Changes in v2: - Add the patch to support the get_fmt ops. - Remove the