Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Laurent Pinchart
[snip] On Monday 26 Jun 2017 16:14:47 Kieran Bingham wrote: > >> +int adv748x_txa_power(struct adv748x_state *state, bool on) > >> +{ > >> +int val; > >> + > >> +val = txa_read(state, ADV748X_CSI_FS_AS_LS); > >> +if (val < 0) > >> +return val; > >> + > >> +/* > >> + * T

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Hans Verkuil
On 26/06/17 17:14, Kieran Bingham wrote: > Hi Hans, > > Thankyou for your review, and apologies for the delay - I was OoO last week. > > > On 19/06/17 10:13, Hans Verkuil wrote: >> On 06/13/2017 02:35 AM, Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> Provide support for the ADV7481 and

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Kieran Bingham
Hi Hans, Thankyou for your review, and apologies for the delay - I was OoO last week. On 19/06/17 10:13, Hans Verkuil wrote: > On 06/13/2017 02:35 AM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >> >> The driver is modelled with 4 subdevices

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-19 Thread Hans Verkuil
On 06/13/2017 02:35 AM, Kieran Bingham wrote: From: Kieran Bingham Provide support for the ADV7481 and ADV7482. The driver is modelled with 4 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs though two CSI TX entities. The HDMI entity is linked to the

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-13 Thread Kieran Bingham
Hi Niklas On 13/06/17 08:33, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch, and great work! Thanks for taking a look. > On 2017-06-13 01:35:07 +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >> >> The driver is modelled w

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-13 Thread Geert Uytterhoeven
Hi Kieran, On Tue, Jun 13, 2017 at 11:32 AM, Kieran Bingham wrote: > On 13/06/17 10:24, Geert Uytterhoeven wrote: >> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> Provide support for the ADV7481 and ADV7482. >>> >>> The driver is modelled with 4 subdevi

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-13 Thread Kieran Bingham
On 13/06/17 10:24, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >> >> The driver is modelled with 4 subdevices to allow simultaneous streaming >> from the AFE (Analog

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-13 Thread Geert Uytterhoeven
Hi Kieran, On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: > From: Kieran Bingham > > Provide support for the ADV7481 and ADV7482. > > The driver is modelled with 4 subdevices to allow simultaneous streaming > from the AFE (Analog front end) and HDMI inputs though two CSI TX > entities. >

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-13 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch, and great work! On 2017-06-13 01:35:07 +0100, Kieran Bingham wrote: > From: Kieran Bingham > > Provide support for the ADV7481 and ADV7482. > > The driver is modelled with 4 subdevices to allow simultaneous streaming > from the AFE (Analog front end) and HDMI

[PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-12 Thread Kieran Bingham
From: Kieran Bingham Provide support for the ADV7481 and ADV7482. The driver is modelled with 4 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs though two CSI TX entities. The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked to the TX