Re: [PATCH v4 1/2] media: atmel-isi: add runtime pm support

2015-05-26 Thread Josh Wu
On 5/26/2015 5:14 PM, Josh Wu wrote: Hi, Laurent On 5/26/2015 4:16 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Tuesday 26 May 2015 16:00:09 Josh Wu wrote: The runtime pm resume/suspend will enable/disable pclk (ISI peripheral clock). And we need to call runtime_pm_get_sy

Re: [PATCH v4 1/2] media: atmel-isi: add runtime pm support

2015-05-26 Thread Josh Wu
Hi, Laurent On 5/26/2015 4:16 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Tuesday 26 May 2015 16:00:09 Josh Wu wrote: The runtime pm resume/suspend will enable/disable pclk (ISI peripheral clock). And we need to call runtime_pm_get_sync()/runtime_pm_put() when we need acc

Re: [PATCH v4 1/2] media: atmel-isi: add runtime pm support

2015-05-26 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Tuesday 26 May 2015 16:00:09 Josh Wu wrote: > The runtime pm resume/suspend will enable/disable pclk (ISI peripheral > clock). > And we need to call runtime_pm_get_sync()/runtime_pm_put() when we need > access ISI registers. In atmel_isi_probe(), remove the is

[PATCH v4 1/2] media: atmel-isi: add runtime pm support

2015-05-26 Thread Josh Wu
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral clock). And we need to call runtime_pm_get_sync()/runtime_pm_put() when we need access ISI registers. In atmel_isi_probe(), remove the isi disable code as in the moment ISI peripheral clock is not enable yet. In the meantime, a