RE: [PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-13 Thread Rapolu, Chiranjeevi
/1] i2c: Add Omnivision OV5670 5M sensor support Hi Chiran, > + > +/* Supported link frequencies */ > +#define OV5670_LINK_FREQ_840MBPS 84000 > +#define OV5670_LINK_FREQ_840MBPS_INDEX 0 > +static const struct ov5670_link_freq_config li

RE: [PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-13 Thread Rapolu, Chiranjeevi
Sakari, Thanks for the review. Submitted v5, responses embedded below. Thanks, Chiran. -Original Message- >Hi Chiranjeevi, > >A few relatively minor comments below. > >On Sat, Jul 01, 2017 at 01:49:06PM -0700, chiranjeevi.rap...@intel.com wrote: >> From: Chiranjeevi Rapolu >> >> Provide

RE: [PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-07 Thread Mani, Rajmohan
Hi Chiran, > + > +/* Supported link frequencies */ > +#define OV5670_LINK_FREQ_840MBPS 84000 > +#define OV5670_LINK_FREQ_840MBPS_INDEX 0 > +static const struct ov5670_link_freq_config link_freq_configs[] = { > + { > + .pixel_rate = 33600, > + .reg_list

Re: [PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-07 Thread Sakari Ailus
Hi Chiranjeevi, A few relatively minor comments below. On Sat, Jul 01, 2017 at 01:49:06PM -0700, chiranjeevi.rap...@intel.com wrote: > From: Chiranjeevi Rapolu > > Provides single source pad with up to 2592x1944 pixels at 10-bit raw > bayer format over MIPI CSI2 two lanes at 840Mbps/lane. > The

[PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-01 Thread chiranjeevi . rapolu
From: Chiranjeevi Rapolu Provides single source pad with up to 2592x1944 pixels at 10-bit raw bayer format over MIPI CSI2 two lanes at 840Mbps/lane. The driver supports following features: - up to 30fps at 5M pixels - manual exposure - digital/analog gain - V-blank/H-blank - test pattern - media