Hi, Mauro
> > +
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
>
> Same comments as on other patches: use SPDX and dev_foo() for printing
> messages.
About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12]
[media] cxd2880-spi: Add support for CXD2880 SPI int
Em Fri, 13 Oct 2017 15:09:34 +0900
escreveu:
> From: Yasunari Takiguchi
>
> This provides the main dvb frontend operation functions
> for the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
>
> Signed-off-by: Yasunari Takiguchi
> Signed-off-by: Masayuki Yamamoto
> Signed-off-by: Hideki Noz
Dear Sean
Hi, Thanks for your review.
We will refer to your comments and consider how to respond for them.
> > + u8 rdata[2];
> > + int ret;
> > +
> > + if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count))
> > + return -EINVAL;
> > +
> > + if (tnrdmd->diver_mode == CXD2880_TNRD
Hello,
Many thanks for the driver.
The ./scripts/checkpatch.pl with --strict has many warnings, some of which might
be nice to have cleaned up.
There are some very minor comments below. Similar constructs are in other files
too.
After reading and understanding through all the code, I think the
From: Yasunari Takiguchi
This provides the main dvb frontend operation functions
for the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: Yasunari Takiguchi
Signed-off-by: Masayuki Yamamoto
Signed-off-by: Hideki Nozawa
Signed-off-by: Kota Yonezawa
Signed-off-by: Toshihiko Mat
