Re: [PATCH v4] media: au0828 - convert to use videobuf2

2015-01-23 Thread Devin Heitmueller
Hi Shuah, > TRY_FMT and S_FMT both don't handle invalid pixelformats. Looks like > there is reason behind this based on the comments: > > /* format->fmt.pix.width only support 720 and height 480 */ > if (width != 720) > width = 720; > if (height != 480) >

Re: [PATCH v4] media: au0828 - convert to use videobuf2

2015-01-23 Thread Shuah Khan
On 01/23/2015 12:17 PM, Shuah Khan wrote: > On 01/23/2015 08:00 AM, Shuah Khan wrote: >> On 01/23/2015 02:50 AM, Hans Verkuil wrote: >>> Hi Shuah, >>> >>> On 01/23/2015 12:42 AM, Shuah Khan wrote: Convert au0828 to use videobuf2. Tested with NTSC. Tested video and vbi devices with xawtv,

Re: [PATCH v4] media: au0828 - convert to use videobuf2

2015-01-23 Thread Shuah Khan
On 01/23/2015 08:00 AM, Shuah Khan wrote: > On 01/23/2015 02:50 AM, Hans Verkuil wrote: >> Hi Shuah, >> >> On 01/23/2015 12:42 AM, Shuah Khan wrote: >>> Convert au0828 to use videobuf2. Tested with NTSC. >>> Tested video and vbi devices with xawtv, tvtime, >>> and vlc. Ran v4l2-compliance to ensure

Re: [PATCH v4] media: au0828 - convert to use videobuf2

2015-01-23 Thread Shuah Khan
On 01/23/2015 02:50 AM, Hans Verkuil wrote: > Hi Shuah, > > On 01/23/2015 12:42 AM, Shuah Khan wrote: >> Convert au0828 to use videobuf2. Tested with NTSC. >> Tested video and vbi devices with xawtv, tvtime, >> and vlc. Ran v4l2-compliance to ensure there are >> no regressions. video now has no fa

Re: [PATCH v4] media: au0828 - convert to use videobuf2

2015-01-23 Thread Hans Verkuil
Hi Shuah, On 01/23/2015 12:42 AM, Shuah Khan wrote: > Convert au0828 to use videobuf2. Tested with NTSC. > Tested video and vbi devices with xawtv, tvtime, > and vlc. Ran v4l2-compliance to ensure there are > no regressions. video now has no failures and vbi > has 3 fewer failures. > > video befo

[PATCH v4] media: au0828 - convert to use videobuf2

2015-01-22 Thread Shuah Khan
Convert au0828 to use videobuf2. Tested with NTSC. Tested video and vbi devices with xawtv, tvtime, and vlc. Ran v4l2-compliance to ensure there are no regressions. video now has no failures and vbi has 3 fewer failures. video before: test VIDIOC_G_FMT: FAIL 3 failures Total: 72, Succeeded: 69, Fa