Re: [PATCH v3 5/7] media: rcar-vin: add DV timings support

2016-04-22 Thread Hans Verkuil
On 04/14/2016 06:17 PM, Ulrich Hecht wrote: > Adds ioctls DV_TIMINGS_CAP, ENUM_DV_TIMINGS, G_DV_TIMINGS, S_DV_TIMINGS, > and QUERY_DV_TIMINGS. > > Signed-off-by: Ulrich Hecht > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 69 > + > 1 file changed, 69 insertion

Re: [PATCH v3 5/7] media: rcar-vin: add DV timings support

2016-04-22 Thread Hans Verkuil
New review of this code. Ignore the previous one. On 04/14/2016 06:17 PM, Ulrich Hecht wrote: > Adds ioctls DV_TIMINGS_CAP, ENUM_DV_TIMINGS, G_DV_TIMINGS, S_DV_TIMINGS, > and QUERY_DV_TIMINGS. > > Signed-off-by: Ulrich Hecht > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 69 > ++

Re: [PATCH v3 5/7] media: rcar-vin: add DV timings support

2016-04-22 Thread Hans Verkuil
On 04/20/2016 06:24 PM, Ulrich Hecht wrote: > On Mon, Apr 18, 2016 at 12:04 PM, Hans Verkuil wrote: >> Hi Ulrich, >> >> This isn't right: this just overwrites the adv7180 input with an HDMI input. >> >> I assume the intention is to have support for both adv7180 and HDMI input and >> to use VIDIOC_

Re: [PATCH v3 5/7] media: rcar-vin: add DV timings support

2016-04-20 Thread Ulrich Hecht
On Mon, Apr 18, 2016 at 12:04 PM, Hans Verkuil wrote: > Hi Ulrich, > > This isn't right: this just overwrites the adv7180 input with an HDMI input. > > I assume the intention is to have support for both adv7180 and HDMI input and > to use VIDIOC_S_INPUT to select between the two. I'm not quite su

Re: [PATCH v3 5/7] media: rcar-vin: add DV timings support

2016-04-18 Thread Hans Verkuil
Hi Ulrich, This isn't right: this just overwrites the adv7180 input with an HDMI input. I assume the intention is to have support for both adv7180 and HDMI input and to use VIDIOC_S_INPUT to select between the two. This really needs some more work, I'm afraid. Regards, Hans On 04/14/2

[PATCH v3 5/7] media: rcar-vin: add DV timings support

2016-04-14 Thread Ulrich Hecht
Adds ioctls DV_TIMINGS_CAP, ENUM_DV_TIMINGS, G_DV_TIMINGS, S_DV_TIMINGS, and QUERY_DV_TIMINGS. Signed-off-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 69 + 1 file changed, 69 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.