Re: [PATCH v3 32/33] smiapp: Add driver.

2012-03-01 Thread Laurent Pinchart
Hi Sakari, On Thursday 01 March 2012 16:01:39 Sakari Ailus wrote: > Laurent Pinchart wrote: [snip] > +return sensor->pixel_array->ctrl_handler.error; > +} > + > +sensor->pixel_array->sd.ctrl_handler = > +&sensor->pixel_arra

Re: [PATCH v3 32/33] smiapp: Add driver.

2012-03-01 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: ... + case V4L2_CID_VBLANK: + exposure = sensor->exposure->val; + + __smiapp_update_exposure_limits(sensor); + + if (exposure > sensor->exposure->maximum) { + sensor->exposure->val =

Re: [PATCH v3 32/33] smiapp: Add driver.

2012-02-29 Thread Sylwester Nawrocki
Hi, On 02/29/2012 10:35 AM, Laurent Pinchart wrote: + if (sensor->pixel_array->ctrl_handler.error) { + dev_err(&client->dev, + "pixel array controls initialization failed (%d)\n", + sensor->pixel_array->ctrl_handler.error); >>> >>> Sh

Re: [PATCH v3 32/33] smiapp: Add driver.

2012-02-29 Thread Laurent Pinchart
Hi Sakari, On Wednesday 29 February 2012 07:41:50 Sakari Ailus wrote: > On Mon, Feb 27, 2012 at 04:38:49PM +0100, Laurent Pinchart wrote: > > On Monday 20 February 2012 03:57:11 Sakari Ailus wrote: > > > From: Sakari Ailus > > > > > > Add driver for SMIA++/SMIA image sensors. The driver exposes