Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-12 Thread Marcel Hasler
Hello 2016-12-12 12:21 GMT+01:00 Mauro Carvalho Chehab : > Em Sun, 11 Dec 2016 13:20:06 +0100 > mahas...@gmail.com escreveu: > >> Sorry about the broken formatting. Here's the diff once more: > > The patch itself looks ok. Just a few comments. > >> >> diff --git a/drivers/media/usb/stk1160/stk1160

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-12 Thread Mauro Carvalho Chehab
Em Sun, 11 Dec 2016 13:20:06 +0100 mahas...@gmail.com escreveu: > Sorry about the broken formatting. Here's the diff once more: The patch itself looks ok. Just a few comments. > > diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c > b/drivers/media/usb/stk1160/stk1160-ac97.c > index 95648ac

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-11 Thread mahasler
Sorry about the broken formatting. Here's the diff once more: diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c index 95648ac..708792b 100644 --- a/drivers/media/usb/stk1160/stk1160-ac97.c +++ b/drivers/media/usb/stk1160/stk1160-ac97.c @@ -23,11 +23,

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-11 Thread Marcel Hasler
Hello 2016-12-06 13:56 GMT+01:00 Mauro Carvalho Chehab : > Em Mon, 5 Dec 2016 22:06:59 +0100 > Marcel Hasler escreveu: > >> Hello >> >> 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >> > On 5 December 2016 at 09:12, Mauro Carvalho Chehab >> > wrote: >> >> Em Sun, 4 Dec 2016 15:25:25 -0300 >> >> E

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-06 Thread Mauro Carvalho Chehab
Em Mon, 5 Dec 2016 22:06:59 +0100 Marcel Hasler escreveu: > Hello > > 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : > > On 5 December 2016 at 09:12, Mauro Carvalho Chehab > > wrote: > >> Em Sun, 4 Dec 2016 15:25:25 -0300 > >> Ezequiel Garcia escreveu: > >> > >>> On 4 December 2016 at 10:01,

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 Thread Ezequiel Garcia
On 5 December 2016 at 18:18, Marcel Hasler wrote: > 2016-12-05 22:06 GMT+01:00 Marcel Hasler : >> Hello >> >> 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >>> On 5 December 2016 at 09:12, Mauro Carvalho Chehab >>> wrote: Em Sun, 4 Dec 2016 15:25:25 -0300 Ezequiel Garcia escreveu:

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 Thread Ezequiel Garcia
On 5 December 2016 at 18:06, Marcel Hasler wrote: > Hello > > 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >> On 5 December 2016 at 09:12, Mauro Carvalho Chehab >> wrote: >>> Em Sun, 4 Dec 2016 15:25:25 -0300 >>> Ezequiel Garcia escreveu: >>> On 4 December 2016 at 10:01, Marcel Hasler wrot

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 Thread Marcel Hasler
2016-12-05 22:06 GMT+01:00 Marcel Hasler : > Hello > > 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >> On 5 December 2016 at 09:12, Mauro Carvalho Chehab >> wrote: >>> Em Sun, 4 Dec 2016 15:25:25 -0300 >>> Ezequiel Garcia escreveu: >>> On 4 December 2016 at 10:01, Marcel Hasler wrote:

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 Thread Marcel Hasler
Hello 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : > On 5 December 2016 at 09:12, Mauro Carvalho Chehab > wrote: >> Em Sun, 4 Dec 2016 15:25:25 -0300 >> Ezequiel Garcia escreveu: >> >>> On 4 December 2016 at 10:01, Marcel Hasler wrote: >>> > Hello >>> > >>> > 2016-12-03 21:46 GMT+01:00 Ezequiel

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 Thread Ezequiel Garcia
On 5 December 2016 at 09:12, Mauro Carvalho Chehab wrote: > Em Sun, 4 Dec 2016 15:25:25 -0300 > Ezequiel Garcia escreveu: > >> On 4 December 2016 at 10:01, Marcel Hasler wrote: >> > Hello >> > >> > 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia : >> >> On 2 December 2016 at 08:05, Mauro Carvalho Che

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 Thread Mauro Carvalho Chehab
Em Sun, 4 Dec 2016 15:25:25 -0300 Ezequiel Garcia escreveu: > On 4 December 2016 at 10:01, Marcel Hasler wrote: > > Hello > > > > 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia : > > > >> On 2 December 2016 at 08:05, Mauro Carvalho Chehab > >> wrote: > >>> Em Sun, 27 Nov 2016 12:11:48 +0100 >

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-04 Thread Ezequiel Garcia
On 4 December 2016 at 10:01, Marcel Hasler wrote: > Hello > > 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia : >> On 2 December 2016 at 08:05, Mauro Carvalho Chehab >> wrote: >>> Em Sun, 27 Nov 2016 12:11:48 +0100 >>> Marcel Hasler escreveu: >>> Allow setting a custom record gain for the intern

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-04 Thread Marcel Hasler
Hello 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia : > On 2 December 2016 at 08:05, Mauro Carvalho Chehab > wrote: >> Em Sun, 27 Nov 2016 12:11:48 +0100 >> Marcel Hasler escreveu: >> >>> Allow setting a custom record gain for the internal AC97 codec (if >>> available). This can be >>> a value bet

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-03 Thread Ezequiel Garcia
On 2 December 2016 at 08:05, Mauro Carvalho Chehab wrote: > Em Sun, 27 Nov 2016 12:11:48 +0100 > Marcel Hasler escreveu: > >> Allow setting a custom record gain for the internal AC97 codec (if >> available). This can be >> a value between 0 and 15, 8 is the default and should be suitable for mos

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-02 Thread Mauro Carvalho Chehab
Em Sun, 27 Nov 2016 12:11:48 +0100 Marcel Hasler escreveu: > Allow setting a custom record gain for the internal AC97 codec (if > available). This can be > a value between 0 and 15, 8 is the default and should be suitable for most > users. The Windows > driver also sets this to 8 without any po

[PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-11-27 Thread Marcel Hasler
Allow setting a custom record gain for the internal AC97 codec (if available). This can be a value between 0 and 15, 8 is the default and should be suitable for most users. The Windows driver also sets this to 8 without any possibility for changing it. Signed-off-by: Marcel Hasler --- drivers/