[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x1

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
> Not sure if you got my point: the main point of removing MODULE_AUTHOR > and other copyright stuff is that such patch may easily be doing something > that could be considered a copyright violation, being bad not only to > the affected driver, but to the entire Kernel. > > So, we need to handle i

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Mauro Carvalho Chehab
Em 05-12-2012 11:27, Federico Vaga escreveu: Ok, I understand. I will write something like this. * Copyright (C) 2012 ST Microelectronics * author: Federico Vaga * Copyright (C) 2010 WindRiver Systems, Inc. * authors: Andreas Kies * Vlad Lungu

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
> > Ok, I understand. I will write something like this. > > > > * Copyright (C) 2012 ST Microelectronics > > * author: Federico Vaga > > * Copyright (C) 2010 WindRiver Systems, Inc. > > * authors: Andreas Kies > > * Vlad Lungu > > Sounds perfect to

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Mauro Carvalho Chehab
Em 05-12-2012 10:24, Federico Vaga escreveu: Thank you Mauro for the good explanation Yeah, there are many changes there that justifies adding you at its authorship, and that's ok. Also, anyone saying the size of your patch will recognize your and ST efforts to improve the driver. However, as

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
Thank you Mauro for the good explanation > Yeah, there are many changes there that justifies adding you at its > authorship, and that's ok. Also, anyone saying the size of your patch > will recognize your and ST efforts to improve the driver. > > However, as some parts of the code were preserved,

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Mauro Carvalho Chehab
Hi Federico, Em 04-12-2012 23:12, Federico Vaga escreveu: On Tuesday 04 December 2012 14:15:15 Mauro Carvalho Chehab wrote: Em 24-09-2012 07:58, Federico Vaga escreveu: This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the contro

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-04 Thread Federico Vaga
On Tuesday 04 December 2012 14:15:15 Mauro Carvalho Chehab wrote: > Em 24-09-2012 07:58, Federico Vaga escreveu: > > This patch re-write the driver and use the videobuf2 > > interface instead of the old videobuf. Moreover, it uses also > > the control framework which allows the driver to inherit >

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-04 Thread Mauro Carvalho Chehab
Em 24-09-2012 07:58, Federico Vaga escreveu: This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: G

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-24 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x1