Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread javier Martin
On 7 February 2012 09:22, Guennadi Liakhovetski wrote: > Hi Javier > > On Tue, 7 Feb 2012, javier Martin wrote: > > [snip] > >> Guennadi, before I send v4: >> Do you agree with the other patches 1, 2 and 4? > > Yes, this time I haven't found anything their to complain about:-) So, > feel free to j

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread Guennadi Liakhovetski
Hi Javier On Tue, 7 Feb 2012, javier Martin wrote: [snip] > Guennadi, before I send v4: > Do you agree with the other patches 1, 2 and 4? Yes, this time I haven't found anything their to complain about:-) So, feel free to just send a v4 of this patch and then your proposed follow-up fixes / i

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread javier Martin
Hi Guennadi, thank you for your attention. On 6 February 2012 19:33, Guennadi Liakhovetski wrote: > Hi Javier > > Thanks for the update! Let's see, whether this one can be improved a bit > more. > > On Mon, 30 Jan 2012, Javier Martin wrote: > >> The way discard buffer was previously handled lead

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-06 Thread Guennadi Liakhovetski
Hi Javier Thanks for the update! Let's see, whether this one can be improved a bit more. On Mon, 30 Jan 2012, Javier Martin wrote: > The way discard buffer was previously handled lead > to possible races that made a buffer that was not > yet ready to be overwritten by new video data. This > is

[PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread Javier Martin
The way discard buffer was previously handled lead to possible races that made a buffer that was not yet ready to be overwritten by new video data. This is easily detected at 25fps just adding "#define DEBUG" to enable the "memset" check and seeing how the image is corrupted. A new "discard" queue