Re: [PATCH v3 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-22 Thread Hans Verkuil
Hi Dave, Thank you for working on this! See my review below: On 20/09/17 18:07, Dave Stevenson wrote: > Add driver for the Unicam camera receiver block on > BCM283x processors. > > Signed-off-by: Dave Stevenson > --- > > Changes from v2. > - Don't store the irq value as it isn't used outside

[PATCH v3 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-20 Thread Dave Stevenson
Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson --- Changes from v2. - Don't store the irq value as it isn't used outside the probe. - Change PIX_FMT_ALL_ defines to avoid potential clashes with 4CCs. - Clock now called "lp" and not "lp_clock"