Re: [PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions

2014-06-10 Thread Sakari Ailus
Hi Prabhakar, Thanks for the review! :-) Prabhakar Lad wrote: Hi Sakari, On Thu, May 29, 2014 at 3:40 PM, Sakari Ailus wrote: Add numeric definitions for menu items used in the smiapp driver's test pattern menu. Signed-off-by: Sakari Ailus --- include/uapi/linux/smiapp.h | 29 +++

Re: [PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions

2014-06-10 Thread Prabhakar Lad
Hi Sakari, On Thu, May 29, 2014 at 3:40 PM, Sakari Ailus wrote: > Add numeric definitions for menu items used in the smiapp driver's test > pattern menu. > > Signed-off-by: Sakari Ailus > --- > include/uapi/linux/smiapp.h | 29 + Don't you need to add an entry in Kbu

Re: [PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions

2014-06-10 Thread Hans Verkuil
On 05/29/14 16:40, Sakari Ailus wrote: > Add numeric definitions for menu items used in the smiapp driver's test > pattern menu. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil > --- > include/uapi/linux/smiapp.h | 29 + > 1 file changed, 29 insertions(+) >

Re: [PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions

2014-05-29 Thread Sakari Ailus
Laurent Pinchart wrote: diff --git a/include/uapi/linux/smiapp.h b/include/uapi/linux/smiapp.h new file mode 100644 index 000..53938f4 --- /dev/null +++ b/include/uapi/linux/smiapp.h @@ -0,0 +1,29 @@ +/* + * include/uapi/linux/smiapp.h + * + * Generic driver for SMIA/SMIA++ compliant camera m

Re: [PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions

2014-05-29 Thread Laurent Pinchart
On Thursday 29 May 2014 17:40:47 Sakari Ailus wrote: > Add numeric definitions for menu items used in the smiapp driver's test > pattern menu. > > Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart > --- > include/uapi/linux/smiapp.h | 29 + > 1 file changed, 2

[PATCH v3 2/3] smiapp: Add driver-specific test pattern menu item definitions

2014-05-29 Thread Sakari Ailus
Add numeric definitions for menu items used in the smiapp driver's test pattern menu. Signed-off-by: Sakari Ailus --- include/uapi/linux/smiapp.h | 29 + 1 file changed, 29 insertions(+) create mode 100644 include/uapi/linux/smiapp.h diff --git a/include/uapi/linux/