Re: [PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Gustavo Padovan
On Fri, 2017-09-08 at 00:09 +0200, Hans Verkuil wrote: > On 09/07/2017 08:42 PM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Rename __close_fd() to close_fd() and export it to be able close > > files > > in modules using file descriptors. > > > > The usecase that motivates this chan

Re: [PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Hans Verkuil
On 09/07/2017 08:42 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Rename __close_fd() to close_fd() and export it to be able close files > in modules using file descriptors. > > The usecase that motivates this change happens in V4L2 where we send > events to userspace with a fd that has

Re: [PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Al Viro
On Thu, Sep 07, 2017 at 06:22:45PM -0300, Gustavo Padovan wrote: > Sorry for my lack of knowledge here and thank you for the explanation, > things are a lot clear to me. For some reasons I were trying to delay > the sharing of the fd to a event later. I can delay the install of it > but that my re

Re: [PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Gustavo Padovan
2017-09-07 Al Viro : > On Thu, Sep 07, 2017 at 03:42:25PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Rename __close_fd() to close_fd() and export it to be able close files > > in modules using file descriptors. > > > > The usecase that motivates this change happens in V4L2

Re: [PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Al Viro
On Thu, Sep 07, 2017 at 03:42:25PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Rename __close_fd() to close_fd() and export it to be able close files > in modules using file descriptors. > > The usecase that motivates this change happens in V4L2 where we send > events to userspace

Re: [PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Eric Biggers
On Thu, Sep 07, 2017 at 03:42:25PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Rename __close_fd() to close_fd() and export it to be able close files > in modules using file descriptors. > > The usecase that motivates this change happens in V4L2 where we send > events to userspace

[PATCH v3 14/15] fs/files: export close_fd() symbol

2017-09-07 Thread Gustavo Padovan
From: Gustavo Padovan Rename __close_fd() to close_fd() and export it to be able close files in modules using file descriptors. The usecase that motivates this change happens in V4L2 where we send events to userspace with a fd that has file installed in it. But if for some reason we have to canc