Re: [PATCH v3 14/14] media: vimc: Create multiplanar parameter and ioctls

2019-04-25 Thread André Almeida
On 4/24/19 8:19 PM, Helen Koike wrote: > > On 4/24/19 8:03 PM, André Almeida wrote: >> Hello Helen, >> >> Thanks for your review! >> >> On 4/24/19 6:32 PM, Helen Koike wrote: >>> Hi André, >>> >>> Thanks for the patch, please see my comments below. >>> >>> On 4/24/19 10:56 AM, André Almeida wrote

Re: [PATCH v3 14/14] media: vimc: Create multiplanar parameter and ioctls

2019-04-24 Thread Helen Koike
On 4/24/19 8:03 PM, André Almeida wrote: > Hello Helen, > > Thanks for your review! > > On 4/24/19 6:32 PM, Helen Koike wrote: >> Hi André, >> >> Thanks for the patch, please see my comments below. >> >> On 4/24/19 10:56 AM, André Almeida wrote: >>> Create multiplanar kernel module parameter t

Re: [PATCH v3 14/14] media: vimc: Create multiplanar parameter and ioctls

2019-04-24 Thread André Almeida
Hello Helen, Thanks for your review! On 4/24/19 6:32 PM, Helen Koike wrote: > Hi André, > > Thanks for the patch, please see my comments below. > > On 4/24/19 10:56 AM, André Almeida wrote: >> Create multiplanar kernel module parameter to define if the driver is >> running in single planar or in

Re: [PATCH v3 14/14] media: vimc: Create multiplanar parameter and ioctls

2019-04-24 Thread Helen Koike
Hi André, Thanks for the patch, please see my comments below. On 4/24/19 10:56 AM, André Almeida wrote: > Create multiplanar kernel module parameter to define if the driver is > running in single planar or in multiplanar mode. Define the device > capabilities and format ioctls according to the mu

[PATCH v3 14/14] media: vimc: Create multiplanar parameter and ioctls

2019-04-24 Thread André Almeida
Create multiplanar kernel module parameter to define if the driver is running in single planar or in multiplanar mode. Define the device capabilities and format ioctls according to the multiplanar kernel parameter. A device can't support both CAP_VIDEO_CAPTURE and CAP_VIDEO_CAPTURE_MPLANAR at the s