Re: [PATCH v3 1/4] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner

2014-09-08 Thread Antti Palosaari
On 09/08/2014 04:18 PM, Akihiro TSUKADA wrote: Moi!, thanks for the review. +static int reg_read(struct mxl301rf_state *state, u8 reg, u8 *val) ... +ret = i2c_transfer(state->i2c->adapter, msgs, ARRAY_SIZE(msgs)); +if (ret >= 0 && ret < ARRAY_SIZE(msgs)) +ret = -EIO; +

Re: [PATCH v3 1/4] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner

2014-09-08 Thread Akihiro TSUKADA
Moi!, thanks for the review. >> +static int reg_read(struct mxl301rf_state *state, u8 reg, u8 *val) ... >> +ret = i2c_transfer(state->i2c->adapter, msgs, ARRAY_SIZE(msgs)); >> +if (ret >= 0 && ret < ARRAY_SIZE(msgs)) >> +ret = -EIO; >> +return (ret == ARRAY_SIZE(msgs)) ? 0

Re: [PATCH v3 1/4] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner

2014-09-08 Thread Antti Palosaari
On 09/07/2014 03:41 PM, tsk...@gmail.com wrote: From: Akihiro Tsukada This patch adds driver for mxl301rf OFDM tuner chips. It is used as an ISDB-T tuner in earthsoft pt3 cards. Note that this driver does not initilize the chip, because the initilization sequence / register setting is not di

[PATCH v3 1/4] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner

2014-09-07 Thread tskd08
From: Akihiro Tsukada This patch adds driver for mxl301rf OFDM tuner chips. It is used as an ISDB-T tuner in earthsoft pt3 cards. Note that this driver does not initilize the chip, because the initilization sequence / register setting is not disclosed. Thus, the driver assumes that the chips are