Re: [PATCH v3 1/3] media: imx: add capture compose rectangle

2019-01-17 Thread Philipp Zabel
Hi Hans, thank you for the review. On Wed, 2019-01-16 at 16:29 +0100, Hans Verkuil wrote: [...] > @@ -290,6 +294,34 @@ static int capture_s_std(struct file *file, void *fh, > v4l2_std_id std) > > return v4l2_subdev_call(priv->src_sd, video, s_std, std); > > } > > > > +static int capture_g

Re: [PATCH v3 1/3] media: imx: add capture compose rectangle

2019-01-16 Thread Hans Verkuil
On 1/11/19 12:10 PM, Philipp Zabel wrote: > Allowing to compose captured images into larger memory buffers > will let us lift alignment restrictions on CSI crop width. > > Signed-off-by: Philipp Zabel > Acked-by: Sakari Ailus > Reviewed-by: Steve Longerbeam > --- > drivers/staging/media/imx/im

[PATCH v3 1/3] media: imx: add capture compose rectangle

2019-01-11 Thread Philipp Zabel
Allowing to compose captured images into larger memory buffers will let us lift alignment restrictions on CSI crop width. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus Reviewed-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prpencvf.c | 3 +- drivers/staging/media/imx/imx-m