Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-05 Thread Laurent Pinchart
Hi Andy, On Sunday 04 March 2012 21:38:54 Andy Walls wrote: > On Sun, 2012-03-04 at 11:20 +0100, Laurent Pinchart wrote: > > On Saturday 03 March 2012 12:35:09 Andy Walls wrote: > > > On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > > > > Add a generic helper function to compute PLL pa

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-04 Thread Andy Walls
On Sun, 2012-03-04 at 11:20 +0100, Laurent Pinchart wrote: > Hi Andy, > > Thanks for the review. > > On Saturday 03 March 2012 12:35:09 Andy Walls wrote: > > On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > > > Add a generic helper function to compute PLL parameters for PLL found in >

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-04 Thread Laurent Pinchart
Hi Sakari, On Sunday 04 March 2012 17:01:30 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Sunday 04 March 2012 00:37:07 Sakari Ailus wrote: > >> On Sat, Mar 03, 2012 at 04:28:14PM +0100, Laurent Pinchart wrote: > >>> Add a generic helper function to compute PLL parameters for PLL found in >

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-04 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: On Sunday 04 March 2012 00:37:07 Sakari Ailus wrote: On Sat, Mar 03, 2012 at 04:28:14PM +0100, Laurent Pinchart wrote: Add a generic helper function to compute PLL parameters for PLL found in several Aptina sensors. [snip] diff --git a/drivers/media/vide

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-04 Thread Laurent Pinchart
Hi Andy, Thanks for the review. On Saturday 03 March 2012 12:35:09 Andy Walls wrote: > On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > > Add a generic helper function to compute PLL parameters for PLL found in > > several Aptina sensors. [snip] > > +int aptina_pll_configure(struct

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-04 Thread Laurent Pinchart
Hi Sakari, On Sunday 04 March 2012 00:37:07 Sakari Ailus wrote: > On Sat, Mar 03, 2012 at 04:28:14PM +0100, Laurent Pinchart wrote: > > Add a generic helper function to compute PLL parameters for PLL found in > > several Aptina sensors. [snip] > > diff --git a/drivers/media/video/aptina-pll.c >

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-03 Thread Sakari Ailus
Hi Laurent, Thanks for the patch! On Sat, Mar 03, 2012 at 04:28:14PM +0100, Laurent Pinchart wrote: > Add a generic helper function to compute PLL parameters for PLL found in > several Aptina sensors. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/video/Kconfig |3 + > driv

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-03 Thread Andy Walls
On Sat, 2012-03-03 at 12:35 -0500, Andy Walls wrote: > On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > > Add a generic helper function to compute PLL parameters for PLL found in > > several Aptina sensors. > > > > Signed-off-by: Laurent Pinchart > > --- > > drivers/media/video/Kconf

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-03 Thread Andy Walls
On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > Add a generic helper function to compute PLL parameters for PLL found in > several Aptina sensors. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/video/Kconfig |3 + > drivers/media/video/Makefile |4 + > dr

[PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-03 Thread Laurent Pinchart
Add a generic helper function to compute PLL parameters for PLL found in several Aptina sensors. Signed-off-by: Laurent Pinchart --- drivers/media/video/Kconfig |3 + drivers/media/video/Makefile |4 + drivers/media/video/aptina-pll.c | 175 +