Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-06-29 Thread jacopo mondi
Hi ov5640 people, I'm happy to finally jump on the bandwagon... I had a few days to test the sensor driver (on 2 platforms) and unfortunately this series breaks MIPI capture for me as well.. On Fri, Jun 01, 2018 at 04:05:58PM -0700, Sam Bobrowicz wrote: > >> On May 21, 2018, at 12:39 AM, Maxi

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-06-04 Thread Maxime Ripard
Hi Sam, On Fri, Jun 01, 2018 at 04:05:58PM -0700, Sam Bobrowicz wrote: > >> On May 21, 2018, at 12:39 AM, Maxime Ripard > >> wrote: > >> > >>> On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: > On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: > On Thursday, May 17, 20

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-06-01 Thread Sam Bobrowicz
>> On May 21, 2018, at 12:39 AM, Maxime Ripard >> wrote: >> >>> On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: Part of the hardcoded initialization seq

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-24 Thread Maxime Ripard
On Wed, May 23, 2018 at 11:31:58AM +0200, Daniel Mack wrote: > Hi Maxime, > > On Tuesday, May 22, 2018 09:54 PM, Maxime Ripard wrote: > > On Mon, May 21, 2018 at 09:39:02AM +0200, Maxime Ripard wrote: > > > On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: > > > > > This set of patch

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-23 Thread Daniel Mack
Hi Maxime, On Tuesday, May 22, 2018 09:54 PM, Maxime Ripard wrote: On Mon, May 21, 2018 at 09:39:02AM +0200, Maxime Ripard wrote: On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: This set of patches is also not working for my MIPI platform (mine has a 12 MHz external clock). I

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-22 Thread Maxime Ripard
On Mon, May 21, 2018 at 09:39:02AM +0200, Maxime Ripard wrote: > On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: > > On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: > > > On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: > > >> > > >> Part of the hardcoded initialization

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-21 Thread Maxime Ripard
On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: > On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: > > On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: > >> > >> Part of the hardcoded initialization sequence is to set up the proper > >> clock > >> dividers. However, this

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-18 Thread Daniel Mack
Hi, On Saturday, May 19, 2018 04:42 AM, Sam Bobrowicz wrote: This set of patches is also not working for my MIPI platform (mine has a 12 MHz external clock). I am pretty sure is isn't working because it does not include the following, which my tests have found to be necessary: 1) Setting pclk p

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-18 Thread Sam Bobrowicz
On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: > On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: >> >> Part of the hardcoded initialization sequence is to set up the proper >> clock >> dividers. However, this is now done dynamically through proper code and as >> such, the static one

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-18 Thread Daniel Mack
On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: Part of the hardcoded initialization sequence is to set up the proper clock dividers. However, this is now done dynamically through proper code and as such, the static one is now redundant. Let's remove it. Signed-off-by: Maxime Ripard -

[PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-17 Thread Maxime Ripard
Part of the hardcoded initialization sequence is to set up the proper clock dividers. However, this is now done dynamically through proper code and as such, the static one is now redundant. Let's remove it. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 46 ++-