On Sat, 2019-07-20 at 11:36 +0200, Hans Verkuil wrote:
> On 7/19/19 11:53 PM, Ezequiel Garcia wrote:
> > On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote:
> > > Hi Ezequiel,
> > >
> > > 'checkpatch.pl --strict' finds way too many issues.
> > >
> > > I'm pretty certain you didn't run it.
> >
On 7/19/19 11:53 PM, Ezequiel Garcia wrote:
> On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote:
>> Hi Ezequiel,
>>
>> 'checkpatch.pl --strict' finds way too many issues.
>>
>> I'm pretty certain you didn't run it.
>>
>
> Shame on me, I did run it and skipped fixing the long lines :-(
>
>> Pl
On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote:
> Hi Ezequiel,
>
> 'checkpatch.pl --strict' finds way too many issues.
>
> I'm pretty certain you didn't run it.
>
Shame on me, I did run it and skipped fixing the long lines :-(
> Please fix the issues and post a v4.
>
> A lot (but not a
Hi Ezequiel,
'checkpatch.pl --strict' finds way too many issues.
I'm pretty certain you didn't run it.
Please fix the issues and post a v4.
A lot (but not all) of the warnings report lines that are too long
and from what I can see most are easily fixed without reducing
readability.
Regards,
Currently, the v4l2 control code is a bit silent on errors.
Add debug messages on (hopefully) most of the error paths.
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Check and noisy-warn if vdev is NULL.
Changes from v1:
* Drop changes in the debug parameter semantics.
* Drop new module d
