Hi Laurent,
On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote:
>> On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> >> + queue->queue.lock = &queue->mutex;
>> >
>> >
Hi Prabhakar,
On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote:
> On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote:
> > Hi Prabhakar,
>
> [Snip]
>
> >> + queue->queue.lock = &queue->mutex;
> >
> > I'm a bit concerned that this would introduce future breakages. Setting
> > the
Hi Laurent,
Thanks for the review.
On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
[Snip]
>>
>> + queue->queue.lock = &queue->mutex;
>
> I'm a bit concerned that this would introduce future breakages. Setting the
> queue.lock pointer enables locking in all vb2_fop_*
Hi Prabhakar,
Thank you for the patch.
On Wednesday 26 November 2014 23:25:44 Lad, Prabhakar wrote:
> This patch drops driver specific wait_prepare() and
> wait_finish() callbacks from vb2_ops and instead uses
> the the helpers vb2_ops_wait_prepare/finish() provided
> by the vb2 core, the lock me
This patch drops driver specific wait_prepare() and
wait_finish() callbacks from vb2_ops and instead uses
the the helpers vb2_ops_wait_prepare/finish() provided
by the vb2 core, the lock member of the queue needs
to be initalized to a mutex so that vb2 helpers
vb2_ops_wait_prepare/finish() can make
