Re: [PATCH v3] media: radio: Critical interrupt bugfix for si470x over i2c

2018-02-26 Thread Hans Verkuil
On 02/27/2018 12:39 AM, Douglas Fischer wrote: > Hans, > > See comments below. Thank you for the quick response on this and all > your patience and help in general with these patches. My pleasure! > > On Mon, 26 Feb 2018 12:57:26 +0100 > Hans Verkuil wrote: > >> On 02/26/2018 03:27 AM, Dougla

Re: [PATCH v3] media: radio: Critical interrupt bugfix for si470x over i2c

2018-02-26 Thread Douglas Fischer
Hans, See comments below. Thank you for the quick response on this and all your patience and help in general with these patches. On Mon, 26 Feb 2018 12:57:26 +0100 Hans Verkuil wrote: > On 02/26/2018 03:27 AM, Douglas Fischer wrote: > > Fixed si470x_start() disabling the interrupt signal, causi

Re: [PATCH v3] media: radio: Critical interrupt bugfix for si470x over i2c

2018-02-26 Thread Hans Verkuil
On 02/26/2018 03:27 AM, Douglas Fischer wrote: > Fixed si470x_start() disabling the interrupt signal, causing tune > operations to never complete. This does not affect USB radios > because they poll the registers instead of using the IRQ line. > > Stylistic and comment changes from v2. > > Signed

[PATCH v3] media: radio: Critical interrupt bugfix for si470x over i2c

2018-02-25 Thread Douglas Fischer
Fixed si470x_start() disabling the interrupt signal, causing tune operations to never complete. This does not affect USB radios because they poll the registers instead of using the IRQ line. Stylistic and comment changes from v2. Signed-off-by: Douglas Fischer --- diff -uprN linux.orig/drivers/