Re: [PATCH v3] [media] s5p-fimc: fix the value of YUV422 1-plane formats

2010-12-18 Thread Sylwester Nawrocki
Hi Hyunwoong, I wish I could apply and test the patch but there are still some problems with it. Now it doesn't apply and it seem to be mangled somehow. Even the patchwork didn't accept it, and v2 looks strange: https://patchwork.kernel.org/patch/412231/ It is better avoided using "==...==" separ

[PATCH v3] [media] s5p-fimc: fix the value of YUV422 1-plane formats

2010-12-16 Thread Hyunwoong Kim
Some color formats are mismatched in s5p-fimc driver. CIOCTRL[1:0], order422_out, should be set 2b'00 not 2b'11 to use V4L2_PIX_FMT_YUYV. Because in V4L2 standard V4L2_PIX_FMT_YUYV means "start + 0: Y'00 Cb00 Y'01 Cr00 Y'02 Cb01 Y'03 Cr01". According to datasheet 2b'00 is right value for V4L2_PIX_F