Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-19 Thread Baruch Siach
Hi Philipp, (Adding firmware loader maintainers to Cc). On Thu, Jan 19, 2017 at 10:44:54AM +0100, Philipp Zabel wrote: > On Wed, 2017-01-18 at 21:33 +0200, Baruch Siach wrote: > > > - if (dev->firmware == 1) { > > > + if (dev->firmware > 0) { > > > > Why would vpu/vpu_fw_*.bin and v4l-coda960-*.

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-19 Thread Philipp Zabel
Hi Baruch, On Wed, 2017-01-18 at 21:33 +0200, Baruch Siach wrote: [...] > > To increase the number of firmware paths, coda_fw_callback has to be > > modified, too. Otherwise it will just ignore firmware[2]: > > Thanks for catching that. But shouldn't we make the firmware files list a > NULL > t

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-18 Thread Baruch Siach
Hi Philipp, On Wed, Jan 18, 2017 at 12:30:29PM +0100, Philipp Zabel wrote: > On Sun, 2017-01-15 at 12:33 +0200, Baruch Siach wrote: > > The Freescale provided imx-vpu looks for firmware files under > > /lib/firmware/vpu > > by default. Make coda look there for firmware files to ease the update pa

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-18 Thread Philipp Zabel
Hi Baruch, On Sun, 2017-01-15 at 12:33 +0200, Baruch Siach wrote: > The Freescale provided imx-vpu looks for firmware files under > /lib/firmware/vpu > by default. Make coda look there for firmware files to ease the update path. > > Cc: Fabio Estevam > Signed-off-by: Baruch Siach > --- > v3: a

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-15 Thread Fabio Estevam
On Sun, Jan 15, 2017 at 8:33 AM, Baruch Siach wrote: > The Freescale provided imx-vpu looks for firmware files under > /lib/firmware/vpu > by default. Make coda look there for firmware files to ease the update path. > > Cc: Fabio Estevam > Signed-off-by: Baruch Siach Reviewed-by: Fabio Estevam

[PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-15 Thread Baruch Siach
The Freescale provided imx-vpu looks for firmware files under /lib/firmware/vpu by default. Make coda look there for firmware files to ease the update path. Cc: Fabio Estevam Signed-off-by: Baruch Siach --- v3: adjust the number of firmware locations in coda_devtype (kbuild test robot) v2: add