On Wed, Sep 12, 2012 at 05:50:54PM +0200, Peter Senna Tschudin wrote:
> Marcos,
>
> > Now that you removed this kfree, you could remove this label too. Very
> > nice your cleanup :)
> Thanks!
>
> >
> >> vpbe_fail_sd_register:
> >> kfree(vpbe_dev->encoders);
> >> vpbe_fail_v4l2_device:
>
Hi Peter,
2012/9/12 Peter Senna Tschudin :
> Marcos,
>
>> Now that you removed this kfree, you could remove this label too. Very
>> nice your cleanup :)
> Thanks!
>
>>
>>> vpbe_fail_sd_register:
>>> kfree(vpbe_dev->encoders);
>>> vpbe_fail_v4l2_device:
>
> The problem removing the label
Marcos,
> Now that you removed this kfree, you could remove this label too. Very
> nice your cleanup :)
Thanks!
>
>> vpbe_fail_sd_register:
>> kfree(vpbe_dev->encoders);
>> vpbe_fail_v4l2_device:
The problem removing the label is that it will require some more work
naming the labels. S
2012/9/12 Peter Senna Tschudin :
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> position p1,p2;
> expression x;
> @@
>
> if (x@p1 =
From: Peter Senna Tschudin
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged
