Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-11 Thread Hugues FRUCHET
Hi Laurent, On 09/10/2018 10:56 PM, Laurent Pinchart wrote: > Hi Hugues, > > On Monday, 10 September 2018 18:14:45 EEST Hugues FRUCHET wrote: >> On 09/07/2018 04:18 PM, Laurent Pinchart wrote: >>> On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote: On 08/16/2018 12:10 PM, jacopo

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-11 Thread Hugues FRUCHET
Hi Jacopo, On 08/25/2018 04:53 PM, jacopo mondi wrote: > Hi Hugues, > one more comment on this patch.. > > On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: >> Mode setting depends on last mode set, in particular >> because of exposure calculation when downscale mode >> change bet

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-10 Thread Laurent Pinchart
Hi Hugues, On Monday, 10 September 2018 18:14:45 EEST Hugues FRUCHET wrote: > On 09/07/2018 04:18 PM, Laurent Pinchart wrote: > > On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote: > >> On 08/16/2018 12:10 PM, jacopo mondi wrote: > >>> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-10 Thread Hugues FRUCHET
Hi Laurent, Steve, On 09/07/2018 04:18 PM, Laurent Pinchart wrote: > Hello Hugues, > > On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote: >> On 08/16/2018 12:10 PM, jacopo mondi wrote: >>> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: >>> Mode setting depends o

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-07 Thread Laurent Pinchart
Hello Hugues, On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote: > On 08/16/2018 12:10 PM, jacopo mondi wrote: > > On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: > > > >> Mode setting depends on last mode set, in particular > >> because of exposure calculation when d

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-08-25 Thread jacopo mondi
Hi Hugues, one more comment on this patch.. On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: > Mode setting depends on last mode set, in particular > because of exposure calculation when downscale mode > change between subsampling and scaling. > At stream on the last mode was wrong

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-08-16 Thread jacopo mondi
Hi Hugues, On Thu, Aug 16, 2018 at 03:07:54PM +, Hugues FRUCHET wrote: > Hi Jacopo, > > On 08/16/2018 12:10 PM, jacopo mondi wrote: > > Hi Hugues, > > thanks for the patch > > > > On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: > >> Mode setting depends on last mode set, i

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-08-16 Thread Hugues FRUCHET
Hi Jacopo, On 08/16/2018 12:10 PM, jacopo mondi wrote: > Hi Hugues, > thanks for the patch > > On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: >> Mode setting depends on last mode set, in particular >> because of exposure calculation when downscale mode >> change between subs

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-08-16 Thread jacopo mondi
Hi Hugues, thanks for the patch On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: > Mode setting depends on last mode set, in particular > because of exposure calculation when downscale mode > change between subsampling and scaling. > At stream on the last mode was wrongly set to

[PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-08-13 Thread Hugues Fruchet
Mode setting depends on last mode set, in particular because of exposure calculation when downscale mode change between subsampling and scaling. At stream on the last mode was wrongly set to current mode, so no change was detected and exposure calculation was not made, fix this. Signed-off-by: Hug