Re: [PATCH v2 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-16 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> +if (camera_status & overrun >> +&& !list_is_last(pcdev->capture.next, &pcdev->capture)) { >> dev_dbg(pcdev->dev, "FIFO overrun! CISR: %x\n", > > Please, put "&&" on the first line:-) Dammit, I thought I had them al

Re: [PATCH v2 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-16 Thread Guennadi Liakhovetski
On Sat, 14 Mar 2009, Robert Jarzmik wrote: > The last buffer queued will often overrun, as the DMA chain > is finished, and the time the dma irq handler is activated, > the QIF fifos are filled by the sensor. > > The fix is to ignore the overrun condition on the last > queued buffer, and restart

[PATCH v2 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-13 Thread Robert Jarzmik
The last buffer queued will often overrun, as the DMA chain is finished, and the time the dma irq handler is activated, the QIF fifos are filled by the sensor. The fix is to ignore the overrun condition on the last queued buffer, and restart the capture only on intermediate buffers of the chain.