Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Hans Verkuil
On 07/16/2016 05:57 PM, Ricardo Ribalda Delgado wrote: > Hi Hans > > On Sat, Jul 16, 2016 at 5:28 PM, Hans Verkuil wrote: > >> >>> + >>> +enum v4l2_rgb_encoding { >>> + V4L2_RGB_ENC_FULL = 32, >>> + V4L2_HSV_ENC_16_235 = 33, >>> +}; >> >> No. > > I was trying to fit also L

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Ricardo Ribalda Delgado
Hi Hans On Sat, Jul 16, 2016 at 5:28 PM, Hans Verkuil wrote: > >> + >> +enum v4l2_rgb_encoding { >> + V4L2_RGB_ENC_FULL = 32, >> + V4L2_HSV_ENC_16_235 = 33, >> +}; > > No. I was trying to fit also Laurent special 16-235 RGB format. I will remove it on future versions. Ca

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Hans Verkuil
On 07/16/2016 04:32 PM, Ricardo Ribalda Delgado wrote: > Hi > > On Sat, Jul 16, 2016 at 4:12 PM, Laurent Pinchart > wrote: > >> I'd still like to know about it for my personal information :-) > > Maybe it is just a very cheap gamma. > >> >>> Anyway, I am inclined to use ycbcr_enc as well. >> >

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Hans Verkuil
On 07/16/2016 04:12 PM, Laurent Pinchart wrote: >> Limited vs full range quantization is handled by the quantization field. >> It's there already. > > Right. I wonder how we'll deal with that when someone will come up with more > than one limited range quantizations, have you thought about it ?

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Ricardo Ribalda Delgado
Hi On Sat, Jul 16, 2016 at 4:12 PM, Laurent Pinchart wrote: > I'd still like to know about it for my personal information :-) Maybe it is just a very cheap gamma. > >> Anyway, I am inclined to use ycbcr_enc as well. > > I'm glad we agree. > Are you thinking about something like this: diff -

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Laurent Pinchart
Hi Hans, On Saturday 16 Jul 2016 15:59:08 Hans Verkuil wrote: > On 07/16/2016 02:38 PM, Laurent Pinchart wrote: >> On Saturday 16 Jul 2016 10:19:29 Hans Verkuil wrote: >>> On 07/15/2016 08:11 PM, Laurent Pinchart wrote: On Friday 15 Jul 2016 18:13:15 Ricardo Ribalda Delgado wrote: > Descr

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Hans Verkuil
On 07/16/2016 02:38 PM, Laurent Pinchart wrote: > Hi Hans, > > On Saturday 16 Jul 2016 10:19:29 Hans Verkuil wrote: >> On 07/15/2016 08:11 PM, Laurent Pinchart wrote: >>> On Friday 15 Jul 2016 18:13:15 Ricardo Ribalda Delgado wrote: Describe the HSV formats Signed-off-by: Ricardo Ri

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Laurent Pinchart
Hi Hans, On Saturday 16 Jul 2016 10:19:29 Hans Verkuil wrote: > On 07/15/2016 08:11 PM, Laurent Pinchart wrote: > > On Friday 15 Jul 2016 18:13:15 Ricardo Ribalda Delgado wrote: > >> Describe the HSV formats > >> > >> Signed-off-by: Ricardo Ribalda Delgado > >> --- > >> > >> Documentation/medi

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Ricardo Ribalda Delgado
Hi Laurent It is actually a very good comment. :) In our case we have implemented the format ourselves in the FPGA and we support both 0-255 and 0-179 Hue ranges. After some weeks of use, only the 0-179 range is used in userpace. The reasons for this is mainly that it is the format used by OpenCV

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-16 Thread Hans Verkuil
On 07/15/2016 08:11 PM, Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Friday 15 Jul 2016 18:13:15 Ricardo Ribalda Delgado wrote: >> Describe the HSV formats >> >> Signed-off-by: Ricardo Ribalda Delgado >> --- >> Documentation/media/uapi/v4l/hsv-formats.rst | 1

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-15 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Friday 15 Jul 2016 18:13:15 Ricardo Ribalda Delgado wrote: > Describe the HSV formats > > Signed-off-by: Ricardo Ribalda Delgado > --- > Documentation/media/uapi/v4l/hsv-formats.rst | 19 ++ > Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 2

[PATCH v2 2/6] [media] Documentation: Add HSV format

2016-07-15 Thread Ricardo Ribalda Delgado
Describe the HSV formats Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/uapi/v4l/hsv-formats.rst | 19 ++ Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 253 + Documentation/media/uapi/v4l/pixfmt.rst| 1 + Documentation/media/uapi/v4