Re: [PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum

2011-05-09 Thread Mauro Carvalho Chehab
Em 09-05-2011 11:15, Steve Kerrison escreveu: > Hi Andreas, > >> I'd prefer returning -EINVAL for unsupported parameters. >> >> [snip] >> >> I already had a patch for this, but forgot to submit it together with >> the frontend.h bits. > > That seems reasonable. Do I need to do anything with this?

Re: [PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum

2011-05-09 Thread Steve Kerrison
Hi Andreas, > I'd prefer returning -EINVAL for unsupported parameters. > > [snip] > > I already had a patch for this, but forgot to submit it together with > the frontend.h bits. That seems reasonable. Do I need to do anything with this? I'm happy for Mauro to scrub my drxd and mxl patches and u

Re: [PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum

2011-05-08 Thread Andreas Oberritter
On 05/08/2011 09:17 PM, Steve Kerrison wrote: > Additional bandwidth modes have been added in frontend.h > drxd_hard.c had no default case so the compiler was warning about > a non-exhausive switch statement. > > This has been fixed by making the default behaviour the same as > BANDWIDTH_AUTO, wit

[PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum

2011-05-08 Thread Steve Kerrison
Additional bandwidth modes have been added in frontend.h drxd_hard.c had no default case so the compiler was warning about a non-exhausive switch statement. This has been fixed by making the default behaviour the same as BANDWIDTH_AUTO, with the addition of a printk to notify if this ever happens.