Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Michael Tretter
On Wed, 30 Jan 2019 10:19:53 -0500, Nicolas Dufresne wrote: > Le mercredi 30 janvier 2019 à 08:47 +0100, Hans Verkuil a écrit : > > On 1/30/19 4:41 AM, Nicolas Dufresne wrote: > > > Hi Hans, > > > > > > Le mercredi 23 janvier 2019 à 11:44 +0100, Hans Verkuil a écrit : > > > > > + if (*npla

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Nicolas Dufresne
Le mercredi 30 janvier 2019 à 08:47 +0100, Hans Verkuil a écrit : > On 1/30/19 4:41 AM, Nicolas Dufresne wrote: > > Hi Hans, > > > > Le mercredi 23 janvier 2019 à 11:44 +0100, Hans Verkuil a écrit : > > > > + if (*nplanes != 0) { > > > > + if (vq->type == V4L2_BUF_TYPE_VIDEO_CAPTUR

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Michael Tretter
On Tue, 29 Jan 2019 22:46:15 -0500, Nicolas Dufresne wrote: > Le mercredi 23 janvier 2019 à 15:17 +0100, Michael Tretter a écrit : > > > I have a patch pending that allows an encoder to spread the compressed > > > output over multiple buffers: > > > > > > https://patchwork.linuxtv.org/patch/53536/

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-29 Thread Hans Verkuil
On 1/30/19 4:41 AM, Nicolas Dufresne wrote: > Hi Hans, > > Le mercredi 23 janvier 2019 à 11:44 +0100, Hans Verkuil a écrit : >>> + if (*nplanes != 0) { >>> + if (vq->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) { >>> + if (*nplanes != 1 || >>> +

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-29 Thread Tomasz Figa
On Wed, Jan 30, 2019 at 12:46 PM Nicolas Dufresne wrote: > > Le mercredi 23 janvier 2019 à 15:17 +0100, Michael Tretter a écrit : > > > I have a patch pending that allows an encoder to spread the compressed > > > output over multiple buffers: > > > > > > https://patchwork.linuxtv.org/patch/53536/

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-29 Thread Nicolas Dufresne
Le mercredi 23 janvier 2019 à 15:17 +0100, Michael Tretter a écrit : > > I have a patch pending that allows an encoder to spread the compressed > > output over multiple buffers: > > > > https://patchwork.linuxtv.org/patch/53536/ > > > > I wonder if this encoder would be able to use it. > > I don

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-29 Thread Nicolas Dufresne
Hi Hans, Le mercredi 23 janvier 2019 à 11:44 +0100, Hans Verkuil a écrit : > > + if (*nplanes != 0) { > > + if (vq->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) { > > + if (*nplanes != 1 || > > + sizes[0] < channel->sizeimage_encoded) > > +

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-23 Thread Michael Tretter
Hi Hans, On Wed, 23 Jan 2019 11:44:05 +0100, Hans Verkuil wrote: > Hi Michael, > > Review comments follow: > > On 01/18/19 14:37, Michael Tretter wrote: > > Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in > > the EV family of the Xilinx ZynqMP SoC. The Zynq UltraScale+ De

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-23 Thread Hans Verkuil
Hi Michael, Review comments follow: On 01/18/19 14:37, Michael Tretter wrote: > Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in > the EV family of the Xilinx ZynqMP SoC. The Zynq UltraScale+ Device > Technical Reference Manual uses the term VCU (Video Codec Unit) for the >

[PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-18 Thread Michael Tretter
Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in the EV family of the Xilinx ZynqMP SoC. The Zynq UltraScale+ Device Technical Reference Manual uses the term VCU (Video Codec Unit) for the encoder, decoder and system integration block. This driver takes care of interacting w