okay, I will continue to work based on your changes unless someone else
has concerns
On Wed, 2017-01-11 at 07:45 +0900, Andi Shyti wrote:
> Hi Sean,
>
> >include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address':
> > unknown attribute
> > >> drivers/media/rc/mtk-cir.c:215:41: s
On Tue, 2017-01-10 at 17:23 +, Sean Young wrote:
> Hi Sean,
>
> > >
> > > The kernel guarantees that calls to the interrupt handler are serialised,
> > > no need to disable the interrupt in the handler.
> >
> > agreed. I will save the mtk irq disable/enable and retest again.
> >
> >
> > >
Hi Sean,
>include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address':
> unknown attribute
> >> drivers/media/rc/mtk-cir.c:215:41: sparse: too many arguments for function
> >> devm_rc_allocate_device
>drivers/media/rc/mtk-cir.c: In function 'mtk_ir_probe':
>drivers/media/
Hi Sean,
The driver is looking very good, we are looking at minor details now.
On Tue, Jan 10, 2017 at 09:59:49PM +0800, Sean Wang wrote:
> On Tue, 2017-01-10 at 11:09 +, Sean Young wrote:
>
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
On Tue, 2017-01-10 at 11:09 +, Sean Young wrote:
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +#define MTK_IR_DEV KBUILD_MODNAME
>
> You could remove this #define and just use KBUILD_MODNAME
I preferred to use MTK_IR_DEV internally that
Hi Sean,
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.10-rc3 next-20170110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/Documentation-de
Hi Sean
Some more review comments.
On Tue, Jan 10, 2017 at 05:13:51PM +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> This patch adds driver for IR controller on MT7623 SoC.
> and should also work on similar Mediatek SoC. Currently
> testing successfully on NEC and SONY remote contr
From: Sean Wang
This patch adds driver for IR controller on MT7623 SoC.
and should also work on similar Mediatek SoC. Currently
testing successfully on NEC and SONY remote controller
only but it should work on others (lirc, rc-5 and rc-6).
Signed-off-by: Sean Wang
Reviewed-by: Sean Young
---
