Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-12-05 Thread Jernej Škrabec
Hi! Jonas Karlman (in CC) and me managed to solve playback issues with interlaced H264 videos. Please check comments below. You can also build and test LibreELEC for H3 from https://github.com/jernejsk/LibreELEC.tv/tree/hw_dec_ffmpeg It has all changes suggested below, except buffer sizes ar

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-30 Thread Jernej Škrabec
Dne petek, 30. november 2018 ob 08:30:47 CET je Maxime Ripard napisal(a): > On Tue, Nov 27, 2018 at 05:30:00PM +0100, Jernej Škrabec wrote: > > > > > +static void _cedrus_write_ref_list(struct cedrus_ctx *ctx, > > > > > +struct cedrus_run *run, > > > > > +

Re: [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-30 Thread Paul Kocialkowski
Hi, On Thu, 2018-11-15 at 15:56 +0100, Maxime Ripard wrote: > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have been tested, and some more advanced features > used in higher profiles are not even implemented. Regarding the preparation of adresse

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-29 Thread Maxime Ripard
On Tue, Nov 27, 2018 at 05:30:00PM +0100, Jernej Škrabec wrote: > > > > +static void _cedrus_write_ref_list(struct cedrus_ctx *ctx, > > > > + struct cedrus_run *run, > > > > + const u8 *ref_list, u8 num_ref, > > > > +

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-27 Thread Jernej Škrabec
Dne torek, 27. november 2018 ob 17:30:00 CET je Jernej Škrabec napisal(a): > Dne torek, 27. november 2018 ob 16:50:28 CET je Maxime Ripard napisal(a): > > Hi Jernej, > > > > Thanks for your review! > > > > On Sat, Nov 24, 2018 at 09:43:43PM +0100, Jernej Škrabec wrote: > > > > +enum cedrus_h264_s

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-27 Thread Jernej Škrabec
Dne torek, 27. november 2018 ob 16:50:28 CET je Maxime Ripard napisal(a): > Hi Jernej, > > Thanks for your review! > > On Sat, Nov 24, 2018 at 09:43:43PM +0100, Jernej Škrabec wrote: > > > +enum cedrus_h264_sram_off { > > > + CEDRUS_SRAM_H264_PRED_WEIGHT_TABLE = 0x000, > > > + CEDRUS_SRAM_H2

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-27 Thread Maxime Ripard
Hi Jernej, Thanks for your review! On Sat, Nov 24, 2018 at 09:43:43PM +0100, Jernej Škrabec wrote: > > +enum cedrus_h264_sram_off { > > + CEDRUS_SRAM_H264_PRED_WEIGHT_TABLE = 0x000, > > + CEDRUS_SRAM_H264_FRAMEBUFFER_LIST = 0x100, > > + CEDRUS_SRAM_H264_REF_LIST_0 = 0

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-24 Thread Jernej Škrabec
Hi, first, thanks you for working on this! I also spend some time working on H264 and I have some comments below. Dne četrtek, 15. november 2018 ob 15:56:50 CET je Maxime Ripard napisal(a): > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have be

[PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-15 Thread Maxime Ripard
Introduce some basic H264 decoding support in cedrus. So far, only the baseline profile videos have been tested, and some more advanced features used in higher profiles are not even implemented. Signed-off-by: Maxime Ripard --- drivers/staging/media/sunxi/cedrus/Makefile | 3 +- drivers/stag