Hi Andy,
On Tuesday 15 November 2011 17:55:55 Andy Shevchenko wrote:
> On Tue, 2011-11-15 at 14:12 +0100, Laurent Pinchart wrote:
> > > > +struct as3645a {
> > > > + struct v4l2_subdev subdev;
> > > > + struct as3645a_platform_data *platform_data;
> > > > +
> > > > + struct mutex
On Tue, 2011-11-15 at 14:12 +0100, Laurent Pinchart wrote:
> > > +struct as3645a {
> > > + struct v4l2_subdev subdev;
> > > + struct as3645a_platform_data *platform_data;
> > > +
> > > + struct mutex power_lock;
> > > + int power_count;
> > > +
> > > + /* Static parameters */
> > > + u8 vref;
> >
Laurent Pinchart wrote:
> Hi Sakari,
Heippa,
> On Tuesday 15 November 2011 16:28:06 Sakari Ailus wrote:
>> Laurent Pinchart wrote:
>>> On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
>
> [snip]
>
> + if (rval & ~AS_FAULT_INFO_INDICATOR_LED)
> + dev_dbg(&client->dev, "No
Hi Sakari,
On Tuesday 15 November 2011 16:28:06 Sakari Ailus wrote:
> Laurent Pinchart wrote:
> > On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
[snip]
> >>> + if (rval & ~AS_FAULT_INFO_INDICATOR_LED)
> >>> + dev_dbg(&client->dev, "No faults, nice\n");
> >>> +
> >>> + return rva
Laurent Pinchart wrote:
> Hi Sakari,
Hi Laurent,
> On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
>> Hi Laurent,
>>
>> Thanks for the patch!! I have a few comments below.
>
> Thanks for the review.
Thanks for the reply to my review. :-)
...
>>> +struct as3645a {
>>> + struct v4l2_s
Hi Sakari,
On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch!! I have a few comments below.
Thanks for the review.
> Laurent Pinchart wrote:
> > This patch adds the driver for the as3645a LED flash controller. This
> > controller supports a high powe
On Mon, 2011-11-14 at 11:34 +0200, Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch!! I have a few comments below.
Most of your comments is about to be addressed by my patches.
Please, wait a bit, And I send my series as I promised.
--
Andy Shevchenko
Intel Finland Oy
--
To unsubsc
Hi Laurent,
Thanks for the patch!! I have a few comments below.
Laurent Pinchart wrote:
> This patch adds the driver for the as3645a LED flash controller. This
> controller supports a high power led in flash and torch modes and an
> indicator light, sometimes also called privacy light.
>
> Sign
This patch adds the driver for the as3645a LED flash controller. This
controller supports a high power led in flash and torch modes and an
indicator light, sometimes also called privacy light.
Signed-off-by: Laurent Pinchart
Signed-off-by: Nayden Kanchev
Signed-off-by: Tuukka Toivonen
Signed-of
