Hello,
On Monday, 7 January 2019 12:38:39 EET Kieran Bingham wrote:
> On 07/01/2019 10:05, Jacopo Mondi wrote:
> > Hi Kieran,
>
>
>
> >>> diff --git a/drivers/media/i2c/adv748x/adv748x.h
> >>> b/drivers/media/i2c/adv748x/adv748x.h index b482c7fe6957..bc2da1b5ce29
> >>> 100644
> >>> --- a/driver
Hi Jacopo,
On 07/01/2019 10:05, Jacopo Mondi wrote:
> Hi Kieran,
>>> diff --git a/drivers/media/i2c/adv748x/adv748x.h
>>> b/drivers/media/i2c/adv748x/adv748x.h
>>> index b482c7fe6957..bc2da1b5ce29 100644
>>> --- a/drivers/media/i2c/adv748x/adv748x.h
>>> +++ b/drivers/media/i2c/adv748x/adv748x.
Hi Kieran,
On Mon, Jan 07, 2019 at 09:49:25AM +, Kieran Bingham wrote:
> Hi Jacopo
>
> On 06/01/2019 15:54, Jacopo Mondi wrote:
> > Add small is_txb() macro to the existing is_txa() and use it where
> > appropriate.
>
> Thank you.
>
> I think this will make the code much better to read than if
Hi Jacopo
On 06/01/2019 15:54, Jacopo Mondi wrote:
> Add small is_txb() macro to the existing is_txa() and use it where
> appropriate.
Thank you.
I think this will make the code much better to read than if (!is_txa).
> Signed-off-by: Jacopo Mondi
Reviewed-by: Kieran Bingham
> ---
> driver
Add small is_txb() macro to the existing is_txa() and use it where
appropriate.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
drivers/media/i2c/adv748x/adv748x.h | 6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/a
