Hi,
On Thu, Aug 10, 2017 at 04:56:50PM +0300, Sakari Ailus wrote:
> Hi Hans,
>
> On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote:
> > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct
> > > gb_light *light)
> > > {
> > > struct gb_connection *connection = get
Hi Hans,
On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote:
> > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct
> > gb_light *light)
> > {
> > struct gb_connection *connection = get_conn_from_light(light);
> > struct device *dev = &connection->bundle->dev
On 10/08/17 15:02, Hans Verkuil wrote:
> On 09/08/17 13:15, Sakari Ailus wrote:
>> From: Rui Miguel Silva
>>
>> We are allocating memory for the v4l2 flash configuration structure and
>> leak it in the normal path. Just use the stack for this as we do not
>> use it outside of this function.
>
> I
On 09/08/17 13:15, Sakari Ailus wrote:
> From: Rui Miguel Silva
>
> We are allocating memory for the v4l2 flash configuration structure and
> leak it in the normal path. Just use the stack for this as we do not
> use it outside of this function.
I'm not sure why this is part of this patch series
Hi Sakari,
On Wed, Aug 09, 2017 at 06:36:59PM +0300, Sakari Ailus wrote:
> Hi Rui,
>
> On Wed, Aug 09, 2017 at 02:20:02PM +0100, Rui Miguel Silva wrote:
> > Hi Sakari,
> > On Wed, Aug 09, 2017 at 02:15:53PM +0300, Sakari Ailus wrote:
> > > From: Rui Miguel Silva
> > >
> > > We are allocating mem
Hi Rui,
On Wed, Aug 09, 2017 at 02:20:02PM +0100, Rui Miguel Silva wrote:
> Hi Sakari,
> On Wed, Aug 09, 2017 at 02:15:53PM +0300, Sakari Ailus wrote:
> > From: Rui Miguel Silva
> >
> > We are allocating memory for the v4l2 flash configuration structure and
> > leak it in the normal path. Just u
Hi Sakari,
On Wed, Aug 09, 2017 at 02:15:53PM +0300, Sakari Ailus wrote:
> From: Rui Miguel Silva
>
> We are allocating memory for the v4l2 flash configuration structure and
> leak it in the normal path. Just use the stack for this as we do not
> use it outside of this function.
>
> Fixes: 2870b
From: Rui Miguel Silva
We are allocating memory for the v4l2 flash configuration structure and
leak it in the normal path. Just use the stack for this as we do not
use it outside of this function.
Fixes: 2870b52bae4c ("greybus: lights: add lights implementation")
Reported-by: Sakari Ailus
Signe
