Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-10-01 Thread Mauro Carvalho Chehab
Em Thu, 28 Sep 2017 18:28:32 +0200 Markus Heiser escreveu: > Hi Mauro, > > > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > > : > > + # Split nested struct/union elements as newer ones > > + my $cont = 1; > > + while ($cont) { > > + $cont = 0; > > > You ignored the

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Markus Heiser
> Am 29.09.2017 um 17:29 schrieb Mauro Carvalho Chehab > : > > Em Thu, 28 Sep 2017 18:28:32 +0200 > Markus Heiser escreveu: > >> Hi Mauro, >> >>> Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab >>> : > >>> +It is possible to document nested structs unions, like:: >>> + >>> + /** >

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Sep 2017 12:29:31 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 28 Sep 2017 18:28:32 +0200 > Markus Heiser escreveu: > > > Hi Mauro, > > > > > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > > > : > > > > +It is possible to document nested structs unions, like:: > > >

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Mauro Carvalho Chehab
Em Thu, 28 Sep 2017 18:28:32 +0200 Markus Heiser escreveu: > Hi Mauro, > > > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > > : > > +It is possible to document nested structs unions, like:: > > + > > + /** > > + * struct nested_foobar - a struct with nested unions and struct

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Sep 2017 17:00:36 +0200 Markus Heiser escreveu: > > None to argue here. If it is part of the language, either comply or use > > some other language that it isn't position oriented. > > Just for info; when Guido van Rossum created python he thought, that > readability counts. With in

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Markus Heiser
> Am 29.09.2017 um 15:33 schrieb Mauro Carvalho Chehab > : >> Sorry if I was unclear. I mean we should not use tabs in reST or in py. > > Ah, OK. > >> In python the indentation is a part of the language syntax, same in >> reST; the indentation is the markup. It's not only me who recommend to >>

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Sep 2017 15:07:05 +0200 Markus Heiser escreveu: > > Am 29.09.2017 um 14:08 schrieb Mauro Carvalho Chehab > > : > > > > Em Thu, 28 Sep 2017 18:28:32 +0200 > > Markus Heiser escreveu: > > > >> Hi Mauro, > >> > >>> Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > >>> : > >

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Markus Heiser
> Am 29.09.2017 um 14:08 schrieb Mauro Carvalho Chehab > : > > Em Thu, 28 Sep 2017 18:28:32 +0200 > Markus Heiser escreveu: > >> Hi Mauro, >> >>> Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab >>> : >>> >> I also untabified the example since tabs in reST are >> a nightmare, especially

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-29 Thread Mauro Carvalho Chehab
Em Thu, 28 Sep 2017 18:28:32 +0200 Markus Heiser escreveu: > Hi Mauro, > > > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > > : > > > I also untabified the example since tabs in reST are > a nightmare, especially in code blocks ... tabulators are the source > of all evil [1] ... > >

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-28 Thread Markus Heiser
Hi Mauro, > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > : > > > > diff --git a/Documentation/doc-guide/kernel-doc.rst > b/Documentation/doc-guide/kernel-doc.rst > index 96012f9e314d..9e63a18cceea 100644 > --- a/Documentation/doc-guide/kernel-doc.rst > +++ b/Documentation/doc-guide/

[PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-27 Thread Mauro Carvalho Chehab
There are several places within the Kernel tree with nested structs/unions, like this one: struct ingenic_cgu_clk_info { const char *name; enum { CGU_CLK_NONE = 0, CGU_CLK_EXT = BIT(0), CGU_CLK_PLL = BIT(1), CGU_CLK_GATE = BIT(2), CGU_CLK_MUX = BIT(3),