Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-05 Thread Sylwester Nawrocki
Hi Sakari, On 02/05/2012 10:04 AM, Sakari Ailus wrote: >>> I wanted to keep the target numbers the same since we're still using >>> exactly the same as the V4L2. >> >> You're right, keeping the numbers same for subdevs and regular video >> nodes may be important. I'm wondering whether we should us

Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-05 Thread Sakari Ailus
Hi Sylwester, On Sat, Feb 04, 2012 at 11:37:38PM +0100, Sylwester Nawrocki wrote: > On 02/04/2012 09:30 PM, Sakari Ailus wrote: > >>> +#define V4L2_SUBDEV_SEL_FLAG_SIZE_GE (1<< 0) > >>> +#define V4L2_SUBDEV_SEL_FLAG_SIZE_LE (1<< 1) > >>> +#define V4L2_SU

Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-04 Thread Sylwester Nawrocki
Hi Sakari, On 02/04/2012 09:30 PM, Sakari Ailus wrote: >>> +#define V4L2_SUBDEV_SEL_FLAG_SIZE_GE (1<< 0) >>> +#define V4L2_SUBDEV_SEL_FLAG_SIZE_LE (1<< 1) >>> +#define V4L2_SUBDEV_SEL_FLAG_KEEP_CONFIG (1<< 2) >>> + >>> +/* active cropping

Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-04 Thread Sakari Ailus
Hi Sylwester, Thanks for the comments!! Sylwester Nawrocki wrote: > On 02/03/2012 12:54 AM, Sakari Ailus wrote: >> Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION >> IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and >> VIDIOC_SUBDEV_G_CROP IOCTLs and

Re: [PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-04 Thread Sylwester Nawrocki
On 02/03/2012 12:54 AM, Sakari Ailus wrote: > Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION > IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and > VIDIOC_SUBDEV_G_CROP IOCTLs and also add new functionality (composing). > > VIDIOC_SUBDEV_G_CROP and VID

[PATCH v2 04/31] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-02-02 Thread Sakari Ailus
Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and VIDIOC_SUBDEV_G_CROP IOCTLs and also add new functionality (composing). VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP continue to be supported. Signed-of