Re: [PATCH v2] tm6000: fix vbuf may be used uninitialized

2011-04-14 Thread Dmitri Belimov
Hi I think it's good. No regression, all works well. With my best regards, Dmitry. > In commit 8aff8ba95155df, most of the manipulations to vbuf inside > copy_streams were gated on if !dev->radio, but one place that touches > vbuf lays outside those gates -- a memcpy of vbuf isn't NULL. If we >

[PATCH v2] tm6000: fix vbuf may be used uninitialized

2011-04-12 Thread Jarod Wilson
In commit 8aff8ba95155df, most of the manipulations to vbuf inside copy_streams were gated on if !dev->radio, but one place that touches vbuf lays outside those gates -- a memcpy of vbuf isn't NULL. If we initialize vbuf to NULL, that memcpy will never happen in the case where we do have dev->radio