Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-23 Thread Kuninori Morimoto
Dear Guennadi > Hm, strange... This doesn't work at all for me. Getting only timeouts. > Have you tested this on Migo-R? Hmm.. strange... It works well on my environment. Of course Migo-R too. my environment is based on your 20091105 patches and my patches Kuninori Morimoto (13): soc-c

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-20 Thread Guennadi Liakhovetski
On Fri, 13 Nov 2009, Kuninori Morimoto wrote: > > Signed-off-by: Kuninori Morimoto > --- > v1 -> v2 > > o remove un-understandable explain. > -> tw9910_query_bus_param need not modify now > o move OUTCTR1 setting to tw9910_set_bus_param > > drivers/media/video/tw9910.c | 38 --

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-19 Thread Kuninori Morimoto
Dear Guennadi Thank you for your comment ! > > I think your order will be added in next patch. > > "Add polarities support" > > I will send it > > OK ? > > Ok, we can do that too. Thank you > This is how the pxa_camera.c driver does it in pxa_camera_set_bus_param(). > What actually happens i

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-19 Thread Guennadi Liakhovetski
On Mon, 16 Nov 2009, Kuninori Morimoto wrote: > > Dear Guennadi > > Thank you > > > Oh, indeed. Ok, but can you add proper support for both high and low > > polarities? > > I think your order will be added in next patch. > "Add polarities support" > I will send it > OK ? Ok, we can do that t

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-15 Thread Kuninori Morimoto
Dear Guennadi Thank you > Oh, indeed. Ok, but can you add proper support for both high and low > polarities? I think your order will be added in next patch. "Add polarities support" I will send it OK ? By the way. Maybe I should ask you about it. My question is that who select ACTIVE HI / LO

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-13 Thread Guennadi Liakhovetski
On Fri, 13 Nov 2009, Kuninori Morimoto wrote: > > Dear Guennadi > > Thank you for checking patch > > > + ret = i2c_smbus_write_byte_data(client, OUTCTR1, > > + VSP_LO | VSSL_VVALID | > > + HSP_LO | HSSL_DVALID); > > > > now

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-13 Thread Kuninori Morimoto
Dear Guennadi Thank you for checking patch > + ret = i2c_smbus_write_byte_data(client, OUTCTR1, > + VSP_LO | VSSL_VVALID | > + HSP_LO | HSSL_DVALID); > > now you dropped VSP_LO | HSP_LO, could you, please, explain, why?

Re: [PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-12 Thread Guennadi Liakhovetski
Hello Morimoto-san On Fri, 13 Nov 2009, Kuninori Morimoto wrote: > > Signed-off-by: Kuninori Morimoto > --- > v1 -> v2 > > o remove un-understandable explain. > -> tw9910_query_bus_param need not modify now > o move OUTCTR1 setting to tw9910_set_bus_param > > drivers/media/video/tw9910.c |

[PATCH v2] soc-camera: tw9910: modify V/H outpit pin setting to use VALID

2009-11-12 Thread Kuninori Morimoto
Signed-off-by: Kuninori Morimoto --- v1 -> v2 o remove un-understandable explain. -> tw9910_query_bus_param need not modify now o move OUTCTR1 setting to tw9910_set_bus_param drivers/media/video/tw9910.c | 38 -- 1 files changed, 8 insertions(+), 30 dele