Re: [PATCH v2] soc-camera: fix missing clean up on error path

2009-06-25 Thread Kuninori Morimoto
Dear Guennadi > > Yes, you're right. Please, try this version, but this is a bigger change, > > also affecting the regular (not error) path, so, I will have to test it > > too. > > Thanks. but I'm very busy now. > Please wait for me. I tested this patch. And I works well for me !! Thank you

Re: [PATCH v2] soc-camera: fix missing clean up on error path

2009-06-21 Thread Kuninori Morimoto
Dear Guennadi Thank you for your hard work > > soc_camera_video_stop is called from icd->ops->remove > > I think it have dead lock by icd->video_lock. > > > > my kernel is from Paul's git and it's Makefile said 2.6.30-rc6 > > Yes, you're right. Please, try this version, but this is a bigger c

[PATCH v2] soc-camera: fix missing clean up on error path

2009-06-18 Thread Guennadi Liakhovetski
soc-camera: fix missing clean up on error path If soc_camera_init_user_formats() fails in soc_camera_probe(), we have to call client's .remove() method to unregister the video device. Reported-by: Kuninori Morimoto Signed-off-by: Guennadi Liakhovetski --- (please use the new V4L Mailing List)