Re: [PATCH v2] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-03 Thread Javier Martinez Canillas
Hello Krzysztof, On 05/03/2016 06:15 AM, Krzysztof Kozlowski wrote: > On Mon, May 02, 2016 at 03:14:22PM -0400, Javier Martinez Canillas wrote: >> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the >> clock field can have a errno pointer value. But s5p_mfc_final_pm() only >> c

Re: [PATCH v2] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-03 Thread Krzysztof Kozlowski
On Mon, May 02, 2016 at 03:14:22PM -0400, Javier Martinez Canillas wrote: > Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the > clock field can have a errno pointer value. But s5p_mfc_final_pm() only > checks if .clock is not NULL before attempting to unprepare and put it. >

Re: [PATCH v2] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 15:14:22 Javier Martinez Canillas wrote: > Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the > clock field can have a errno pointer value. But s5p_mfc_final_pm() only > checks if .clock is not NULL before attempting to unprepare and put it. > > This lead

[PATCH v2] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-02 Thread Javier Martinez Canillas
Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the clock field can have a errno pointer value. But s5p_mfc_final_pm() only checks if .clock is not NULL before attempting to unprepare and put it. This leads to the following warning in clk_put() due s5p_mfc_final_pm(): WARNING: